Skip to content
This repository has been archived by the owner on Oct 2, 2022. It is now read-only.

fix: remove unnecessary async keyword #132

Merged
merged 1 commit into from
Aug 21, 2021

Conversation

danielkcz
Copy link
Contributor

What did you implement:

I've removed the async keyword to make the loader compatible with cosmiconfigSync().

How did you implement it:

See above :)

How can we verify it:

Try to use the plugin with cosmiconfigSync().

Tasks:

  • Write tests
  • Write documentation
  • Fix linting errors
  • Make sure code coverage hasn't dropped
  • Provide verification config / commands / resources
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@jacksteamdev
Copy link

jacksteamdev commented Aug 12, 2021

@FredyC ESLint require-await is no joke! 🤦‍♂️

If @hassankhan isn't maintaining this anymore, have you thought about publishing this on NPM?

@hassankhan
Copy link
Collaborator

Hi @jacksteamdev @FredyC 👋

Unfortunately I don't have commit rights to this repo as I'm not an @EndemolShineGroup employee any more. I've been meaning to fork the repo and republish it under @radicalcondor, but I didn't have a firm deadline for it 😅

@hassankhan hassankhan changed the title Remove unnecessary async keyword fix: remove unnecessary async keyword Aug 21, 2021
@hassankhan hassankhan merged commit b8b671b into EndemolShineGroup:develop Aug 21, 2021
@hassankhan
Copy link
Collaborator

Just got my commit privileges restored, thanks for the PR @FredyC 🎉

@hassankhan
Copy link
Collaborator

hassankhan commented Aug 21, 2021

Ahh just realised that Travis CI doesn't work any more, going to need to switch over to GitHub Actions before the Ci can release a new version. I've created a new issue for that: #185

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants