Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CED-2010: improve desktop search bar #7

Merged
merged 12 commits into from
Dec 4, 2024

Conversation

hroth1994
Copy link

@hroth1994 hroth1994 commented Dec 4, 2024

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-2010

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

On desktop, the search bar is currently implemented in the nav bar so that if the search bar is open, mousing over a top level menu item (Tips & guides, About us) will cause it to close. This new design resolves this issue.

πŸ₯Ό Testing

🧐 Feedback Requested / Focus Areas

  • General

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@hroth1994 hroth1994 requested a review from mpleroux December 4, 2024 16:32
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the CI failure before I have a look? Thanks!

Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - one optional thing.

es-vue-base/src/lib-components/EsNavBar.vue Outdated Show resolved Hide resolved
@hroth1994 hroth1994 merged commit c4128c0 into main Dec 4, 2024
1 check passed
@hroth1994 hroth1994 deleted the ced-2010-improve-desktop-search-bar branch December 4, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants