Configuration Changes #1
Conversation
| install: | ||
| npm install | ||
| npx lerna bootstrap | ||
| npm --prefix es-vue-base run build |
There was a problem hiding this comment.
👍 thanks for working this bit out
| @@ -16,4 +20,5 @@ publish: | |||
|
|
|||
| .PHONY: update | |||
| update: | |||
| lerna bootstrap | |||
| npm --prefix es-vue-base run build | |||
There was a problem hiding this comment.
Running make build will trigger the build script in es-vue-base. What do you think about the pattern of make build && make update?
There was a problem hiding this comment.
Yea I think there's still a few things to figure out here. I'm not convinced this is right yet, I think we should try starting from scratch once this is stable again.
| @@ -0,0 +1,151 @@ | |||
| # EnergySage Design System | |||
There was a problem hiding this comment.
I'm a little confused why this is showing up as an addition on the PR
There was a problem hiding this comment.
I just renamed the case readme.md -> README.md
| [*] | ||
| charset = utf-8 | ||
| end_of_line = lf | ||
| indent_size = 2 |
There was a problem hiding this comment.
Would you be cool with increasing the indent size to 4?
There was a problem hiding this comment.
I'm cool with it just didn't want to introduce formatting/linting changes in this PR. We should talk more broadly about what to do with es-bs-base and es-bs-extends in terms of linting.
| @@ -1,4 +1,3 @@ | |||
| // EnergySage's Flavor of Bootstrap | |||
| @import './variables'; | |||
| @@ -0,0 +1,73 @@ | |||
| module.exports = { | |||
| settings: { | |||
| 'import/resolver': { | |||
There was a problem hiding this comment.
I'm a little confused how this works in a rollup context.
There was a problem hiding this comment.
It doesn't. Each tool has their own alias resolver. This just tells eslint what @ means in an import statement.
| "eslint": "^8.20.0", | ||
| "eslint-config-energysage": "^2.2.1", | ||
| "eslint-config-prettier": "^8.5.0", | ||
| "eslint-import-resolver-webpack": "^0.13.2", |
There was a problem hiding this comment.
Should https://www.npmjs.com/package/@rollup/plugin-eslint be used in this project?
There was a problem hiding this comment.
I didn't really understand this plugins use case. It seems to just look at the rollup config for files to lint, given we are linting everything I didn't think it was necessary.
| @@ -1,77 +1,80 @@ | |||
| <script> | |||
There was a problem hiding this comment.
I'm assuming this is just prettier updates. FWIW I forgot to delete this file. Hopefully there wasn't any manual work updating it.
There was a problem hiding this comment.
Yep, it's gone in another PR.
| @@ -1,7 +1,12 @@ | |||
| { | |||
| "name": "root", | |||
| "private": true, | |||
| "scripts": { | |||
| "watch": "nodemon --exec make update" | |||
There was a problem hiding this comment.
This feels hacky, but I like it 👍
There was a problem hiding this comment.
Super hacky, not sure we actually want to keep it but it does work. I think you're right that nx will solve this problem for us but I tried for a bit and couldn't get it working.
|
|
||
| ```bash | ||
| $ git remote -v | ||
| origin [email protected]:EnergySage/es-ds.git (fetch) | ||
| origin [email protected]:EnergySage/es-ds.git (push) | ||
| ``` | ||
|
|
||
| Next you should run `make update`. This will kick-off installing requirements for the repo. | ||
| Next you should run `make install`. This will kick-off installing requirements for the repo. |
There was a problem hiding this comment.
Nice catch 👍 , sorry for the confusion here.
Merge First