-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CED 1189 update twitter social icon #1258
Conversation
β
Β Linked to Task CED-1189 Β· Updating Twitter Social Icon in Footer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Jaissica, this looks really nice! Great work with modifying the svg file especially.
Last is just to fix the formatting, let's try another method that will make this easy in the future: If you go to the .vscode
folder, first go to the extensions file and make sure you have all of them installed ( you likely already have some from other repos). Then, copy settings.json.example
into a new file settings.json
in that folder, and reload VSCode. When you open the files in this PR it'll then show the lint warnings, and just saving them again should automatically reformat.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
π Linked issue
https://energysage.atlassian.net/jira/software/c/projects/CED/boards/63?search=1189&selectedIssue=CED-1189
β Type of change
π Description
Updated the twitter logo with X logo in the footer.
The change is required to have the updated icon in the footer.
π₯Ό Testing
I have tested the changes locally(http://localhost:8500/atoms/icons). Ran the tests and updated the test snapshots accordingly.
π§ Feedback Requested / Focus Areas
π Checklist