Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CED 1189 update twitter social icon #1258

Merged
merged 8 commits into from
Feb 15, 2024
Merged

Conversation

jaissica
Copy link
Contributor

πŸ”— Linked issue

https://energysage.atlassian.net/jira/software/c/projects/CED/boards/63?search=1189&selectedIssue=CED-1189

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Updated the twitter logo with X logo in the footer.
The change is required to have the updated icon in the footer.

πŸ₯Ό Testing

I have tested the changes locally(http://localhost:8500/atoms/icons). Ran the tests and updated the test snapshots accordingly.

🧐 Feedback Requested / Focus Areas

  • Anything I have missed? Feedback always appreciated!

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@jaissica jaissica requested a review from lgeggleston February 13, 2024 15:09
Copy link

swarmia bot commented Feb 13, 2024

βœ… Β Linked to Task CED-1189 Β· Updating Twitter Social Icon in Footer
➑️  Part of Epic CED-1164 · Unplanned enhancement requests Q1

Copy link
Contributor

@lgeggleston lgeggleston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jaissica, this looks really nice! Great work with modifying the svg file especially.

Last is just to fix the formatting, let's try another method that will make this easy in the future: If you go to the .vscode folder, first go to the extensions file and make sure you have all of them installed ( you likely already have some from other repos). Then, copy settings.json.example into a new file settings.json in that folder, and reload VSCode. When you open the files in this PR it'll then show the lint warnings, and just saving them again should automatically reformat.

Copy link
Contributor

@lgeggleston lgeggleston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jaissica jaissica merged commit 9e54300 into main Feb 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants