Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made side nav persistent on XL and XXL breakpoints #1277

Merged
merged 3 commits into from
Apr 17, 2024

Conversation

ericdouglaspratt
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt commented Apr 17, 2024

πŸ”— Linked issue

  • n/a

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • For easier navigability and discoverability on desktop, exposed the side nav and made it persistent on the xl and xxl breakpoints (i.e. as soon as there's enough room) - reduces the need to dive in and out of category pages to navigate between child/leaf pages (i.e. fewer clicks) and gives newcomers an idea, at a single glance, of what our design system contains
  • Retained <b-container> around the page content so it still goes up to the full max width, except on lower xl breakpoint where it's slightly constrained below its max width
  • Enhanced the navigation to indicate the current page within its list of links
  • Fixed a typo on the home page
  • EsNavBar and EsFooter pages are unchanged, as those use a different layout, need to display at full viewport width, and are being removed from the design system soon anyway

XL breakpoint with side nav shown

Screen Shot 2024-04-17 at 7 26 39 AM

Upper XL breakpoint with room enough that the entire layout centers within viewport, as before

Screen Shot 2024-04-17 at 7 27 08 AM

XXL breakpoint

Screen Shot 2024-04-17 at 7 27 20 AM

LG breakpoint and below remain unchanged

Screen Shot 2024-04-17 at 7 26 18 AM

πŸ₯Ό Testing

  • Tested locally

🧐 Feedback Requested / Focus Areas

  • Overall

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@ericdouglaspratt ericdouglaspratt changed the title feat: made side nav persistent on XL and XXL breakpooints feat: made side nav persistent on XL and XXL breakpoints Apr 17, 2024
Copy link
Member

@tomleo tomleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘

@ericdouglaspratt ericdouglaspratt merged commit d255068 into main Apr 17, 2024
1 check passed
@ericdouglaspratt ericdouglaspratt deleted the persistent-side-nav branch April 17, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants