-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CED-1724: new folder structure and publish process for v3 #1467
CED-1724: new folder structure and publish process for v3 #1467
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your updates to make all the 2.0 processes legacy
and to the package files make sense; README updates also look good! The updated Makefile commands make sense too I think, though I have limited experience with them so curious for Tom & Eric's thoughts when they're back.
General question, though looks like it works fine, what are the benefits/considerations to moving away from Lerna or a different monorepo manager?
Agreed! No rush in any case.
For the time being, I didn't mess with lerna because I didn't want to break the legacy build and publishing which does rely on lerna. And to be honest, I'm also not sure what value lerna adds compared to just having the sequence of steps in the makefile. Maybe the automatic version increment comes from there? This is definitely something for Tom and Eric to weigh in on. I mentioned it in the big PR as well, but it seems like it'd be easier to shed the legacy stuff in this branch. The old (v2) design system could be maintained on its own branch after merging v3. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a high-level my suggestion would be to keep commands like lint
, test
, and publish
inclusive to all packages in this mono-repo.
Most of the time we'll mostly want to target newer projects, and so I'd suggest perhaps adding commands like X-next
to target prime specific repos for faster linting and testing and building.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few things inline, also couldn't find good documentation around tsconfig's in mono-repos π€, but otherwise π
π Linked issue
https://energysage.atlassian.net/browse/CED-1724
β Type of change
π Description
npm publish
is invoked fores-bs-base
(using the alpha tag) andes-ds-components
π₯Ό Testing
Manually tested publish process
π§ Feedback Requested / Focus Areas
es-ds-styles
andes-ds-components
in order to get the latest version. My attempts with usingnpm update
were unsuccessful. Do you have any pointers here?π Checklist