CED-1822 EsRating follow-up TODOs

[tomleo]

🔗 Linked issue

• https://energysage.atlassian.net/browse/CED-1822

❓ Type of change

• 📖 Documentation (updates to the documentation or readme)
• 🐞 Bug fix (a non-breaking change that fixes an issue)
• 👌 Enhancement (improving an existing functionality like performance)
• ✨ New feature (a non-breaking change that adds functionality)
• ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

• resolving double alerts by using @focus instead of @change

🥼 Testing

• manual

🧐 Feedback Requested / Focus Areas

• Fading the scale transition after a "click" is still an open TODO

📝 Checklist

• I have linked an issue or discussion.
• I have updated the documentation accordingly.
• I have documented testing approach

[swarmia]

✅  Linked to Task CED-1822 · EsRating follow-up TODOs
➡️  Part of Epic CED-1339 · Build Vue 3 design system [MC]

[hroth1994]

Mentioned this on Slack - the change event is still triggering twice, you just can't tell anymore without the alert. I do like the new experience in your PR, but I'm not sure removing the alert is ideal since it's a good way of observing that PrimeVue has this issue

[nathanielwarner]

@tomleo can you add the PR description and address formatting errors?

[hroth1994]

This is looking good, a few comments and it needs a PR description. I would include in the description what is being fixed (updates to the docs page and resolving double alerts by using @Focus instead of @change) and what still needs to be changed (star transform persisting after click)

[hroth1994]

Looking good! A few more thoughts:

[hroth1994]

LGTM! 🌟