Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CED-1855 rename b- prefix to es- prefix #1542

Merged
merged 5 commits into from
Oct 3, 2024
Merged

CED-1855 rename b- prefix to es- prefix #1542

merged 5 commits into from
Oct 3, 2024

Conversation

tomleo
Copy link
Member

@tomleo tomleo commented Oct 2, 2024

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Rename b- components to es-

🥼 Testing

  • Manual

🧐 Feedback Requested / Focus Areas

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@swarmia Swarmia
Copy link

swarmia bot commented Oct 2, 2024

✅  Linked to Task CED-1855 · Replace b- prefixes with es- and add documentation
➡️  Part of Epic CED-1339 · Build Vue 3 design system MVP [HC]

ericdouglaspratt
ericdouglaspratt approved these changes Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you have a CI failure around linting/formatting but otherwise looks good!

@tomleo tomleo merged commit c5cc22c into esds-3.0-vue3-primevue Oct 3, 2024
1 check passed
@tomleo tomleo deleted the CED-1855 branch October 3, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdouglaspratt ericdouglaspratt ericdouglaspratt approved these changes

@nathanielwarner nathanielwarner Awaiting requested review from nathanielwarner nathanielwarner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tomleo @ericdouglaspratt