Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CED-1782: v3 EsCtaBanner #1545

Closed
wants to merge 707 commits into from
Closed

CED-1782: v3 EsCtaBanner #1545

wants to merge 707 commits into from

Conversation

mpleroux
Copy link
Member

@mpleroux mpleroux commented Oct 4, 2024

🔗 Linked issue

CED-1782: Create v3 EsCtaBanner

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

  • Created v3 EsCtaBanner component in new Design System feature branch
  • Created new docs page
  • Changed b-row and b-col references to es-row and es-col
  • Converted script to Composition API

🥼 Testing

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

hroth1994 and others added 30 commits September 4, 2024 16:40
@hroth1994
Merge branch 'esds-3.0-vue3-primevue' into ced-1746-es-carousel
37825d2
@tomleo
feat: tweak script names
92f3ca5
@tomleo
Merge pull request #1509 from EnergySage/linting-tweaks
f58415a 
Add formatting logic
@tomleo
Merge remote-tracking branch 'origin/esds-3.0-vue3-primevue' into CED…
769c879 
…-1815
@tomleo
Merge remote-tracking branch 'origin/esds-3.0-vue3-primevue' into CED…
924aff0 
…-1815
@tomleo
chore: apply formatting
e6ac213
@hroth1994
docs: add product-image class
900192e
@nathanielwarner
fix: minor linting fixes, everything passing now, enforce linting on …
e10b9ff 
…pr to vue branch
@nathanielwarner
Merge branch 'esds-3.0-vue3-primevue' into CED-1815
5a1545b
@lgeggleston
Merge branch 'esds-3.0-vue3-primevue' into CED-1756-v3-es-support
7072d46
@lgeggleston
format: run format
d496bad
@lgeggleston
format: run format pt 2
a02f17b
@tomleo
feat: change ternary lint rule
80e5ce5
@tomleo
fix: sentence case
5f581ab
@tomleo
chore: apply formatting
f594e5b
@lgeggleston
Merge pull request #1511 from EnergySage/CED-1756-v3-es-support
9c163d9 
CED-1756 V3 EsSupport
@tomleo
Merge pull request #1514 from EnergySage/rule-tweak
b366166 
Rule tweak
@tomleo
Merge remote-tracking branch 'origin/esds-3.0-vue3-primevue' into CED…
1bb5b4c 
…-1815
@tomleo
chore: apply formatting
d739ef0
@nathanielwarner
chore: actually apply eslint to vue files and stuff
a46a8f9
@nathanielwarner
Merge branch 'esds-3.0-vue3-primevue' into actually-apply-eslint-to-vue
8da449a
@tomleo
Merge pull request #1506 from EnergySage/CED-1815
49b7228 
CED-1815  Fix accessibility issue in v3 EsRadioButton
@tomleo
feat: wip
2a7e7b9
@nathanielwarner
chore: fix some linting errors, avoid conflicts between prettier and …
03ec6d7 
…eslint
@nathanielwarner
Merge branch 'esds-3.0-vue3-primevue' into actually-apply-eslint-to-vue
fc47ca2
@nathanielwarner
chore: add build step to ci so linting can work
d75b4f4
@nathanielwarner
Merge pull request #1515 from EnergySage/actually-apply-eslint-to-vue
0dec8be 
Actually apply eslint to vue
@hroth1994
Merge branch 'esds-3.0-vue3-primevue' into ced-1746-es-carousel
91d1bdc
@hroth1994
chore: auto format
da6dcf7
@hroth1994
chore: update packages
0f81d48
tomleo and others added 25 commits October 3, 2024 12:49
@tomleo
fix: small tweaks
638aace
@tomleo
chore: apply formatting
0d33844
@tomleo
Merge pull request #1542 from EnergySage/CED-1855
c5cc22c 
CED-1855 rename b- prefix to es- prefix
@mpleroux
feat: update marketplace report link
3ac6699
@hroth1994
Merge branch 'esds-3.0-vue3-primevue' into ced-1785-es-form-v3
e228a41
@tomleo
Merge remote-tracking branch 'origin/esds-3.0-vue3-primevue' into ced…
ef14e54 
…-1822-more-es-rating-double-alert
@tomleo
feat: remove alert
1912f97
@hroth1994
fix: changes based on feedback
ecf8b87
@hroth1994
style: apply formatting
b9f87b5
@RANE1021
reworked code type, css changes for details, corrected disabled prop …
d6f603c 
…for input
@RANE1021
Merge branch 'esds-3.0-vue3-primevue' into CED-1760-Create-v3-EsVerif…
1a92a05 
…icationCode-using-PrimeVue
@RANE1021
simplify clear code, change b-row & b-col to es-row & es-col
40ba5cf
@RANE1021
make format
d082e00
@RANE1021
Merge pull request #1526 from EnergySage/CED-1760-Create-v3-EsVerific…
2a2c3e3 
…ationCode-using-PrimeVue

feat: Ced 1760 create v3 es verification code using prime vue
@tomleo
Merge remote-tracking branch 'origin/esds-3.0-vue3-primevue' into ced…
ab72bd6 
…-1822-more-es-rating-double-alert
@tomleo
chore: tweak padding
c4f17b8
@tomleo
Merge pull request #1531 from EnergySage/ced-1822-more-es-rating-doub…
4311416 
…le-alert

CED-1822 EsRating follow-up TODOs
@hroth1994
Merge branch 'esds-3.0-vue3-primevue' into ced-1785-es-form-v3
385862b
@hroth1994
fix: use es-spinner
020776c
@hroth1994
Merge pull request #1541 from EnergySage/ced-1785-es-form-v3
d83a8df 
feat: es-form v3
@ericdouglaspratt
fix: component links from Corners page, made textarea URL slug consis…
dbdb20e 
…tent with other pages
@ericdouglaspratt
Merge pull request #1544 from EnergySage/ced-1774-corner-links
875f913 
fix: component links from Corners page, made textarea URL slug consistent with other pages
@mpleroux
Merge branch 'esds-3.0-vue3-primevue' into CED-1867-navbar-report
c477673
@mpleroux
Merge pull request #1543 from EnergySage/CED-1867-navbar-report
5b1741e 
feat: update marketplace report link
@mpleroux
Component, docs page
7762c42
@swarmia Swarmia
Copy link

swarmia bot commented Oct 4, 2024

✅  Linked to Task CED-1782 · Create v3 EsCtaBanner
➡️  Part of Epic CED-1339 · Build Vue 3 design system MVP [HC]

@mpleroux mpleroux closed this Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomleo tomleo Awaiting requested review from tomleo tomleo is a code owner

@ericdouglaspratt ericdouglaspratt Awaiting requested review from ericdouglaspratt ericdouglaspratt is a code owner

@nathanielwarner nathanielwarner Awaiting requested review from nathanielwarner nathanielwarner is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mpleroux @hroth1994 @tomleo @nathanielwarner @lgeggleston @ericdouglaspratt @RANE1021