-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CED-1851 Create esSkeleton, SkeletonWrapper, SkeletonImg #1547
CED-1851 Create esSkeleton, SkeletonWrapper, SkeletonImg #1547
Conversation
β
Β Linked to Task CED-1851 Β· Create v3 EsSkeleton, EsSkeletonImg, EsSkeletonWrapper using PrimeVue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A beautiful docs page! And the components look and work great.
Just some small things.
Also, can we add primevue/skeleton
to the list of optimized dependencies in the es-ds-components nuxt.config.js so we don't get the reload-after-the-page-already-loaded behavior in local dev?
βΉ β¨ new dependencies optimized: primevue/skeleton
βΉ β¨ optimized dependencies changed. reloading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! One suggestion but good to go
π Linked issue
https://energysage.atlassian.net/browse/CED-1851
β Type of change
π Description
EsSkeleton
using PrimeVue Skeleton and supporting props from BSkeleton with the exception of 'variant' and 'type'EsSkeletonWrapper
based on the bootstrap helper componentEsSkeletonImg
based on bootstrap helper componentπ₯Ό Testing
Based documentation examples on the real usages of
b-skeleton
currently in our repos, and made sure that those instances could be created using the prop set on the new components.π§ Feedback Requested / Focus Areas
π Checklist