Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CED-1851 Create esSkeleton, SkeletonWrapper, SkeletonImg #1547

Merged
merged 12 commits into from
Oct 8, 2024

Conversation

lgeggleston
Copy link
Contributor

@lgeggleston lgeggleston commented Oct 7, 2024

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-1851

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Created EsSkeleton using PrimeVue Skeleton and supporting props from BSkeleton with the exception of 'variant' and 'type'
  • created EsSkeletonWrapper based on the bootstrap helper component
  • created EsSkeletonImg based on bootstrap helper component
    • Differences: did not implement the 'throb' animation or 'card-img' prop, because they are not in current codebase usages and 'card-img' opened a bit of a styling can of worms.

πŸ₯Ό Testing

Based documentation examples on the real usages of b-skeleton currently in our repos, and made sure that those instances could be created using the prop set on the new components.

🧐 Feedback Requested / Focus Areas

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

Copy link

swarmia bot commented Oct 7, 2024

@lgeggleston lgeggleston requested a review from mpleroux October 7, 2024 14:01
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A beautiful docs page! And the components look and work great.

Just some small things.

Also, can we add primevue/skeleton to the list of optimized dependencies in the es-ds-components nuxt.config.js so we don't get the reload-after-the-page-already-loaded behavior in local dev?

β„Ή ✨ new dependencies optimized: primevue/skeleton
β„Ή ✨ optimized dependencies changed. reloading

es-ds-docs/pages/molecules/skeleton.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/skeleton.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/skeleton.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/skeleton.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/skeleton.vue Outdated Show resolved Hide resolved
es-ds-docs/pages/molecules/skeleton.vue Outdated Show resolved Hide resolved
es-ds-components/components/es-skeleton-img.vue Outdated Show resolved Hide resolved
es-ds-components/components/es-skeleton-img.vue Outdated Show resolved Hide resolved
es-ds-components/components/es-skeleton-img.vue Outdated Show resolved Hide resolved
es-ds-components/components/es-skeleton-img.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@ericdouglaspratt ericdouglaspratt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! One suggestion but good to go

es-ds-docs/pages/molecules/skeleton.vue Outdated Show resolved Hide resolved
@lgeggleston lgeggleston merged commit 909ed20 into esds-3.0-vue3-primevue Oct 8, 2024
1 check passed
@lgeggleston lgeggleston deleted the CED-1851-create-es-skeleton branch October 8, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants