-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add preference center link to footer #1566
base: esds-3.0-vue3-primevue
Are you sure you want to change the base?
Conversation
π |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise looks good! Nice work on the layout change, and I verified that it works in the GTM preview as well
height: height, | ||
width: width, | ||
}" | ||
aria-labelledby="California Consumer Privacy Act (CCPA) Opt-Out Icon" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now this is not read aloud. It should be aria-label. aria-labelledby is used to reference a different component.
π Linked issue
https://energysage.atlassian.net/browse/CED-2034
β Type of change
π Description
π₯Ό Testing
es-cms-pages
toes-ds-components
and openinglocalhost:8700
in GTM preview mode and clicking the βYour privacy choicesβ link.π§ Feedback Requested / Focus Areas
π Checklist