Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preference center link to footer #1566

Open
wants to merge 8 commits into
base: esds-3.0-vue3-primevue
Choose a base branch
from

Conversation

hroth1994
Copy link
Contributor

@hroth1994 hroth1994 commented Dec 23, 2024

πŸ”— Linked issue

https://energysage.atlassian.net/browse/CED-2034

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Left align legal links
  • Add link for β€œYour privacy choices” that opens the cookie preferences center. It is prefixed by the CCPA icon to the left and has alt text of β€œCalifornia Consumer Privacy Act (CCPA) Opt-Out Icon”.

πŸ₯Ό Testing

  • Tested by linking es-cms-pages to es-ds-components and opening localhost:8700 in GTM preview mode and clicking the β€œYour privacy choices” link.

🧐 Feedback Requested / Focus Areas

  • General

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@hroth1994 hroth1994 changed the title feat: add cookie notice and preference center links to footer feat: add preference center link to footer Jan 13, 2025
@hroth1994 hroth1994 marked this pull request as ready for review January 13, 2025 21:58
@nathanielwarner
Copy link
Collaborator

πŸ‘€

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good! Nice work on the layout change, and I verified that it works in the GTM preview as well

height: height,
width: width,
}"
aria-labelledby="California Consumer Privacy Act (CCPA) Opt-Out Icon"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now this is not read aloud. It should be aria-label. aria-labelledby is used to reference a different component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants