Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add peek props to carousel and update numDots calculation #1567

Merged
merged 2 commits into from
Jan 7, 2025

Conversation

lgeggleston
Copy link
Contributor

πŸ”— Linked issue

Relevant to https://energysage.atlassian.net/browse/CED-1974

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

  • Added peekDesktop and peekMobile props to EsCarousel because they were part of the design for the carousel on whole-home page, but also has come up before as something we want to support for more carousels
  • Tweaked the numDots logic to take into account numScroll - the arrow placement was wonky when numScroll was not the same as numVisible

πŸ₯Ό Testing

🧐 Feedback Requested / Focus Areas

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.
  • I have documented testing approach

@nathanielwarner
Copy link
Collaborator

πŸ‘€

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One other question- do we have a design for how the "peek" behavior should look? On https://www.energysage.com/whole-home/ it seems like the "peek" extends all the way to the edge of the screen, whereas here the amount needs to be hardcoded from the carousel it seems?

es-ds-components/components/es-carousel.vue Show resolved Hide resolved
@lgeggleston
Copy link
Contributor Author

One other question- do we have a design for how the "peek" behavior should look? On https://www.energysage.com/whole-home/ it seems like the "peek" extends all the way to the edge of the screen, whereas here the amount needs to be hardcoded from the carousel it seems?

@nathanielwarner Good question; the design wasn't put down in Figma but this did go through informal review with Asheeta - main answer in the case of whole-home is that the current design with centering/no container was itself a workaround, and Asheeta requested for the cut-off just on the rightmost card like this, as well as something that we might use for future carousels.

Copy link
Collaborator

@nathanielwarner nathanielwarner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the info on the circular issue!

@lgeggleston lgeggleston merged commit 9d4e195 into esds-3.0-vue3-primevue Jan 7, 2025
1 check passed
@lgeggleston lgeggleston deleted the carousel-peek-styling-updates branch January 7, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants