-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 1.18 support as well as support for other versions #3
base: master
Are you sure you want to change the base?
Conversation
Sorry for the delay in reviewing this. Would it be possible to make this more DRY, e.g. having all the dumpers in a common project, with an interface implemented by each version-specific package? That way we don't need to replace things in a million files if we change them, |
Sorry for my late response. How should I handle the common project dumpers, since the existing dumpers each rely on imports from different Minecraft versions? |
I would add some kind of |
Could I ask for an example of what you are describing so I have a better idea of what to do? What I am understanding so far is that you want for me to make the dumpers from each module implement common interfaces, and to not use generics. |
Yes, I'm using the word "generic" here as the non-technical term. I don't really know what example to show that wouldn't just be doing the refactor, since it should be pretty simple? The main point is to just not have a separate |
But |
That's why I said
By adding types like what is needed, you don't need the MC type anymore. Seems like you probably need a |
So I would create interfaces in the common module, and create classes in the version-specific modules which implement the interfaces and delegate the methods to the |
It's not strictly necessary for |
Things have become complicated now as I realize that |
I think you're making this too complicated -- we only need a small bit of the API that |
We also use Oh, wait, I can just replace And I can remove the |
I have finished what you asked, though I still need to update the 1.18 module from 1.18.1 to 1.18.2, and I need to get the 1.14.4 and 1.15.2 modules' category dumpers to work. I need to merge the latest commit on the master branch into it, too. |
I have now noticed that the newer commits of this repository have removed the category dumpers. May I ask about why that was done, and should I remove them from the older ones as well? Update: I figured out that they were actually consolidated with their respective |
... although the 1.18.2 module can't run properly right now. I commented out the category dumpers in 1.18.2 because it seems that the newest commit for this repository has removed them entirely, and I am waiting for an answer as to whether I should remove them from all versions. I also changed some `System.err` usages to `System.out` because it was more appropriate, and updated some plugins.
May as well do this to all of them.
I am not too experienced with Gradle, so feel free to change how I did this.
It's fine as a `File`, I guess.
Also, added a translucency tag to
blocks.json
.1.14.4 and 1.15.2 do not have completely functional category dumpers yet, but it is fine for now because I doubt that anyone is going to use them soon.