Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

start-automated-server.bat doesn't support IPv6 #4043

Closed
algorythm opened this issue Jan 12, 2022 · 3 comments
Closed

start-automated-server.bat doesn't support IPv6 #4043

algorythm opened this issue Jan 12, 2022 · 3 comments
Labels
Bug Status: Fixed In Next Release

Comments

@algorythm
Copy link

Modpack Version

d363897

Describe your issue.

Starting the server won't work on Windows if you have a public IPv6 address.

The script makes a ping to minecraftforge.net and tries to look for TTL in the response. Apparently, if the server returns an IPv6 address, the TTL is not included:

image

As I personally have a public IPv6 address, the server responds with IPv6 as well, causing the script to think, that I don't have internet.

Crash Report

No response

Latest Log

No response

Have you modified the modpack?

No

User Modifications

No response

Did the issue happen in singleplayer or on a server?

Server
@algorythm algorythm added the Bug label Jan 12, 2022
algorythm added a commit to algorythm/Enigmatica6 that referenced this issue Jan 12, 2022
@algorythm
Force IPv4 ping in start-automated-server.bat
9bcbbce 
Ping does not respond with a TTL if the server responds with an IPv6
address. This essentially means that the script will think the user does
not have internet, if they have a public IPv6 address. Forcing IPv4 in
the ping command, ensures TTL gets returned, and the startup can
proceed.

Closes EnigmaticaModpacks#4043
@algorythm algorythm mentioned this issue Jan 12, 2022
Closed
@NielsPilgaard
Copy link
Collaborator

Thanks for the report and fix, very nice of you :D
I've decided to remove the check entirely, it's pretty redundant anyway.

@algorythm
Copy link
Author

algorythm commented Jan 14, 2022 •
edited by unfurl-links bot
Loading

Cool. I reckon this will be relevant for your other mod packs as well. Also, if you ever plan to update the script with latest from https://github.com/AllTheMods/Server-Scripts/, you'll have the issue again, as the problems stems from that. I've submitted a PR there as well AllTheMods/Server-Scripts#89.

GitHub
Server Startup Scripts. Contribute to AllTheMods/Server-Scripts development by creating an account on GitHub.

@NielsPilgaard
Copy link
Collaborator

I've refactored the script for 1.18 a while back, so that's already fixed 👍 But thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Status: Fixed In Next Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Force IPv4 ping in start-automated-server.bat algorythm/Enigmatica6
2 participants
@algorythm @NielsPilgaard