-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Downstream plugin inconsistently reports a leading wild type (unmutated) amino acid #342
Comments
Hi @susannasiebert, the Downstream plugin never reports a leading wild type amino acid. It always reports the amino acid of the first codon which is affected by the variant allele. But I need to emphasise that I'm not expecting that when --hgvs is used that it has an effect on the calculations in the Downstream plugin. This looks like a bug to me and we need to investigate further. I will keep you updated here with any progress we make on the issue. For now I would recommend that the user shouldn't use --hgvs when annotating the input data which is then used by your tool. Best wishes, |
Please see griffithlab/pVACtools#576 (comment) for example results from running VEP 100 with and without the |
Thank you for letting us know. We are still working on a fix and will let you know as soon as we have updated the VEP code. |
Thank you for looking into it. On a (marginally) related note: would it be possible to output the version of a plugin in the plugin's VCF header entry? This would make it possible for our downstream tools to ensure that the new/fixed plugin was used during annotation. |
@at7 I was wondering if there had been any updates on this issue? |
Hi @susannasiebert, Best regards, |
Wonderful. Thank you! |
Hi Susanna, |
@at7 we were able to resolve this issue on our end by switching to a different plugin we wrote ourselves called Is there a process to submit new plugins to VEP for consideration? |
We are happy to receive pull requests for new VEP plugins. Our contribution guide is here. Please let me know if you have any more questions. Best wishes, |
We've encountered situations were sometimes the Downstream plugin will report one leading wildtype amino acid and sometimes it does not. For example this user (griffithlab/pVACtools#576) using the GRCh37 cache reports result that do not include a leading wild type amino acid while this user's prediction on GRCh38 (griffithlab/pVACtools#484) does return a leading wild type amino acid. I'm not sure if the different reference builds are indeed the problem but in our variant prediction pipelines using GRCh38 and VEP95 we are also encountering the leading wildtype amino acid.
Is this intentional and if so, is there a heuristic to determine when a Downstream prediction includes this leading wild type amino acid?
The text was updated successfully, but these errors were encountered: