Remove POSIX ceil dep from Downstream #371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is really all that helpful, I hope that it is so I thought I'd submit a PR anyway. I refactored the Downstream plugin a few months ago but got busy with other projects. It removes the dependency on POSIX ceil and simplifies how the sequence "to translate" is obtained. In my limited testing, it produced the same results as the current version (v2.3). I found this PR helpful when I was debugging pVACtools (please see #342). I wonder if this could be helpful for you @at7?