Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate species topology check #896

Conversation

twalsh-ebi
Copy link
Contributor

@twalsh-ebi twalsh-ebi commented Feb 17, 2025

Description

This PR reinstates the species-topology check in division_config.t.

It also removes numbering from division-config tests.

Note that the Travis checks currently failing are expected because the allowed_species.json file has been updated for release/115, but the species topology is in review ensembl-compara PR 889.


For code reviewers: code review SOP

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.66%. Comparing base (1b90627) to head (383151a).
Report is 1 commits behind head on release/115.

Additional details and impacted files
@@               Coverage Diff               @@
##           release/115     #896      +/-   ##
===============================================
- Coverage        60.67%   60.66%   -0.01%     
===============================================
  Files              212      212              
  Lines            23026    23026              
  Branches          3632     3632              
===============================================
- Hits             13971    13969       -2     
  Misses            7836     7836              
- Partials          1219     1221       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Simarpreet-Kaur-Bhurji Simarpreet-Kaur-Bhurji merged commit 8ce6ade into Ensembl:release/115 Feb 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants