-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant symbolic alt to so term hash #1643
base: main
Are you sure you want to change the base?
Conversation
@nuno-agostinho, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same concern as expressed in Ensembl/ensembl-variation#1075 (review).
Otherwise, I just have small suggestions.
our @EXPORT_OK = qw( | ||
get_SO_term | ||
&check_format | ||
&_valid_region_regex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to export _valid_region_regex
, it was only being used within check_format
for ensembl-variation
(confirm?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is used in -
return [] unless $region =~ &_valid_region_regex(); check_format
forensembl-variation
. We need to import for that. I am just giving preference to remove redundancy.
Co-authored-by: Nuno Agostinho <[email protected]>
Reported in Ensembl/VEP_plugins#710
Also see Ensembl/ensembl-variation#1075