Fix column name when selecting from gene_archive table #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ens-bwalts
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Sorry for letting this through in the first place. This should fix the issue and it looks like it's compatible with the two places get_max_stable_id_from_gene_archive is called.
Note that this got into release/106 so we will need the same bugfix PR against that branch as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In merged PR #573, 'stable_id' was mistakenly used when selecting from gene_archive table, while this table doesn't have a 'stable_id' column.
Use case
Fix sql query to use $type (which could be gene_stable_id, transcript_stable_id, ...) instead of 'stable_id'.
Benefits
This script currently fails without this change.
Possible Drawbacks
None
Testing
Have you added/modified unit tests to test the changes?
If so, do the tests pass/fail?
Have you run the entire test suite and no regression was detected?