Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update backup compression options that call pg_basebackup. #847

Merged
merged 1 commit into from
Oct 2, 2023

Conversation

didiermichel
Copy link
Contributor

add backup_compression=none to create an uncompressed archive that only supports backup_compression_level=0.
for pg >= 15:
update zstd compression level range from -131072 to 22 update lz4 compression level range from 0 to 12

For PG < 15:
Allow using backup_compression_level=0 with backup_compression=gzip algorithm.

In configuration 'none' can be used as value and not identified as None value.

@didiermichel didiermichel marked this pull request as ready for review September 21, 2023 13:52
@didiermichel
Copy link
Contributor Author

This PR should solve #815

barman/compression.py Outdated Show resolved Hide resolved
barman/compression.py Show resolved Hide resolved
@didiermichel didiermichel force-pushed the BAR-104_compression_level_zero branch 3 times, most recently from 111431a to 420c715 Compare October 2, 2023 11:05
Copy link
Contributor

@gcalacoci gcalacoci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

add `backup_compression=none` to create an uncompressed archive
that only supports `backup_compression_level=0`.
for pg >= 15:
update `zstd` compression level range from `-131072` to `22`
update `lz4` compression level range from `0` to `12`

For PG < 15:
Allow using `backup_compression_level=0` with `backup_compression=gzip` algorithm.

In configuration 'none' can be used as value and not identified as None value.

Closes#815
@edb-sonar-app
Copy link

edb-sonar-app bot commented Oct 2, 2023

@didiermichel didiermichel merged commit e5ed444 into master Oct 2, 2023
9 checks passed
@didiermichel didiermichel deleted the BAR-104_compression_level_zero branch October 2, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants