-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note in the manual about recovery near retention policy #980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need to revisit this.
This implementation is fragile as it is because the WALs required by the recovery process to complete could be vanished once the KEEP is released.
We need to discuss a different approach.
94c6405
to
5702196
Compare
This commit Closes#200. It is adding a note to the recovery section in the documentation manual alerting the user about the possibility of the backup getting obsolete while the recovery process is ongoing and what to do to prevent that. The team first thought about a solution that could handle this automatically but many arguments were against this, specially because it could introduce unwanted behaviour on recover and the fact that `keep` feature is there to help. References: BAR-222 Signed-off-by: Andre <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
44f9571
to
868b55e
Compare
This commit Closes: #200 .
It adds a note to the recovery section of the documentation manual. This note informs users about the risk of backup obsolescence and deletion during the recovery process, particularly when retention policy rules are enforced, and provides guidance on how to prevent this issue.
Initially, the team considered implementing an automatic solution for this problem. However, several concerns were raised, including the potential for unintended side effects during recovery, the existing
keep
feature designed to assist with backups, and the need for users to be fully aware of the implications and procedures during recovery—an operation often conducted under stressful situations.References: BAR-222