fix: allow offline init with unobfuscated config (#143)

* fix: allow offline init with unobfuscated config * bump version
Eppo-exp · Dec 20, 2024 · ffd6204 · ffd6204
1 parent e46e838
commit ffd6204
Show file tree

Hide file tree

Showing 3 changed files with 43 additions and 3 deletions.
diff --git a/eppo/build.gradle b/eppo/build.gradle
@@ -7,7 +7,7 @@ plugins {
 }
 
 group = "cloud.eppo"
-version = "4.3.4-SNAPSHOT"
+version = "4.3.5"
 
 android {
     buildFeatures.buildConfig true

diff --git a/eppo/src/androidTest/java/cloud/eppo/android/EppoClientTest.java b/eppo/src/androidTest/java/cloud/eppo/android/EppoClientTest.java
@@ -369,6 +369,46 @@ private void runTestCases() {
     }
   }
 
+  @Test
+  public void testOfflineInit() throws IOException {
+    testOfflineInitFromFile("flags-v1.json");
+  }
+
+  @Test
+  public void testObfuscatedOfflineInit() throws IOException {
+    testOfflineInitFromFile("flags-v1-obfuscated.json");
+  }
+
+  public void testOfflineInitFromFile(String filepath) throws IOException {
+    AssetManager assets = ApplicationProvider.getApplicationContext().getAssets();
+
+    InputStream stream = assets.open(filepath);
+    int size = stream.available();
+    byte[] buffer = new byte[size];
+    int numBytes = stream.read(buffer);
+    stream.close();
+
+    CompletableFuture<Void> futureClient =
+        new EppoClient.Builder("DUMMYKEY", ApplicationProvider.getApplicationContext())
+            .isGracefulMode(false)
+            .offlineMode(true)
+            .assignmentLogger(mockAssignmentLogger)
+            .forceReinitialize(true)
+            .initialConfiguration(buffer)
+            .buildAndInitAsync()
+            .thenAccept(client -> Log.i(TAG, "Test client async buildAndInit completed."));
+
+    Double result =
+        futureClient
+            .thenApply(
+                clVoid -> {
+                  return EppoClient.getInstance().getDoubleAssignment("numeric_flag", "bob", 99.0);
+                })
+            .join();
+
+    assertEquals(3.14, result, 0.1);
+  }
+
   @Test
   public void testCachedConfigurations() {
     // First initialize successfully

diff --git a/eppo/src/main/java/cloud/eppo/android/EppoClient.java b/eppo/src/main/java/cloud/eppo/android/EppoClient.java
@@ -175,13 +175,13 @@ public Builder assignmentCache(IAssignmentCache assignmentCache) {
     public Builder initialConfiguration(byte[] initialFlagConfigResponse) {
       this.initialConfiguration =
           CompletableFuture.completedFuture(
-              Configuration.builder(initialFlagConfigResponse, true).build());
+              new Configuration.Builder(initialFlagConfigResponse).build());
       return this;
     }
 
     public Builder initialConfiguration(CompletableFuture<byte[]> initialFlagConfigResponse) {
       this.initialConfiguration =
-          initialFlagConfigResponse.thenApply(ic -> Configuration.builder(ic, true).build());
+          initialFlagConfigResponse.thenApply(ic -> new Configuration.Builder(ic).build());
       return this;
     }