Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: latest from the common package and move /api to baseUrl #132

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

typotter
Copy link
Collaborator

towards FF-3558
🎟️ FF-3558

Motivation and Context

Most, nearly all in fact, of the SDKs use a baseUrl of https://fscdn.eppo.cloud/api and endpoint constants of /flag-config/v1/config and /flag-config/v1/bandits for flag and bandit requests.

All of the SDKs need to follow the common convention in order for our cross-SDK testing tools (scenario testing, benchmarking) to work seamlessly.

@typotter typotter enabled auto-merge (squash) November 15, 2024 07:47
@typotter typotter disabled auto-merge November 15, 2024 07:47
@@ -7,7 +7,7 @@ plugins {
}

group = "cloud.eppo"
version = "4.3.2-SNAPSHOT"
version = "4.3.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you planning to cut a new release with this change?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@typotter
Copy link
Collaborator Author

Holding off on this for now; need to reorient work around a major version bump if/when we proceed

@typotter typotter self-assigned this Nov 28, 2024
@typotter typotter requested a review from felipecsl January 6, 2025 20:36
@typotter typotter assigned felipecsl and unassigned typotter Jan 6, 2025
@typotter
Copy link
Collaborator Author

typotter commented Jan 6, 2025

Updated to latest and adds baseUrl in a back-compatible manner

@typotter typotter merged commit c30c719 into main Jan 6, 2025
3 checks passed
@typotter typotter deleted the tp/ff3558 branch January 6, 2025 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants