External request - make 'EppoClient.refreshConfiguration' public #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarsilv
approved these changes
May 31, 2024
There was a problem hiding this comment.
Hey hey! Thanks for helping us improve our Android SDK. We'll merge this change, but I'm going to add a @Deprecated annotation to it.
The reason is that this particular method also does some cache loading stuff. Ideally, we'd pull out the HTTP stuff into a standalone public refresh method. That being said, this newly-exposed method will still accomplish what you want. It will load whatever was previously fetched from the cache and update it when the fetch completes. However, it's a roundabout way that does more work than it has to, and we have plans to expand the API to have a true refresh request--hence the "deprecation".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, an Android dev here. Recently we have started using your Android SDK in our app and noticed that there is no possibility to refresh the configuration after the app initialization, because the function 'refreshConfiguration' is private.
Sometimes we may need to refresh the configuration during the app's session. Could you make this method public so we would be able to refresh the configuration when needed? It is possible in iOS SDK, so I assume it could be possible in Android SDK as well?
Best,
Pawel