Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export sdk-common-jvm to consumers of android-sdk #71

Merged
merged 2 commits into from
Jun 24, 2024
Merged

fix: Export sdk-common-jvm to consumers of android-sdk #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
304b06a
fix: Export `sdk-common-jvm` to consumers of `android-sdk`
felipecsl Jun 24, 2024
4b8e6b2
pass in SubjectAttributes to getStringAssignment
felipecsl Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eppo/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ ext.versions = [


dependencies {
implementation 'cloud.eppo:sdk-common-jvm:2.0.0-SNAPSHOT'
api 'cloud.eppo:sdk-common-jvm:2.0.0-SNAPSHOT'
implementation "androidx.core:core:${versions.androidx_core}"
implementation "com.squareup.okhttp3:okhttp:${versions.okhttp}"
implementation "com.github.zafarkhaja:java-semver:${versions.semver}"
Expand Down
4 changes: 3 additions & 1 deletion example/src/main/java/cloud/eppo/androidexample/SecondActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import com.geteppo.androidexample.R;

import cloud.eppo.android.EppoClient;
import cloud.eppo.ufc.dto.SubjectAttributes;

public class SecondActivity extends AppCompatActivity {
private EditText experiment;
Expand Down Expand Up @@ -51,7 +52,8 @@ private void handleAssignment() {
return;
}

String assignedVariation = EppoClient.getInstance().getStringAssignment(experimentKey, subjectId, "");
String assignedVariation = EppoClient.getInstance().getStringAssignment(
experimentKey, subjectId, new SubjectAttributes(), "");
appendToAssignmentLogView("Assigned variation: " + assignedVariation);
}

Expand Down
Loading