Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement IS_NULL operator and INTEGER value type #8

Merged
merged 11 commits into from
May 29, 2024
Merged

Implement IS_NULL operator and INTEGER value type #8

merged 11 commits into from
May 29, 2024

Conversation

typotter
Copy link
Collaborator

@typotter typotter commented May 23, 2024 •
edited
Loading

  • IS_NULL operator type and matching condition
  • INTEGER value type and corresponding client method
  • small refactorings.

@typotter typotter requested a review from leoromanovsky May 23, 2024 22:40
@typotter typotter changed the title Implement IS_NULL operator Implement IS_NULL operator and INTEGER value type May 27, 2024
@leoromanovsky leoromanovsky requested review from aarsilv and schmit May 28, 2024 19:24
schmit
schmit approved these changes May 28, 2024
View reviewed changes
Copy link

@schmit schmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Little experience with .net but changes make sense to me!

leoromanovsky
leoromanovsky reviewed May 28, 2024
View reviewed changes
dot-net-sdk/EppoClient.cs Show resolved Hide resolved
dot-net-sdk/EppoClient.cs Outdated Show resolved Hide resolved
dot-net-sdk/dto/EppoValueDeserializer.cs Show resolved Hide resolved
dot-net-sdk/http/ExperimentConfigurationRequester.cs Show resolved Hide resolved
dot-net-sdk/validators/RuleValidator.cs Outdated Show resolved Hide resolved
@typotter
Copy link
Collaborator Author

Thanks for the review. Updates made. @leoromanovsky PTAL

@typotter
Copy link
Collaborator Author

Thanks @leoromanovsky and @schmit

@typotter typotter merged commit e7a1907 into main May 29, 2024
1 check passed
@typotter typotter deleted the isnull branch May 29, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoromanovsky leoromanovsky leoromanovsky approved these changes

@schmit schmit schmit approved these changes

@aarsilv aarsilv Awaiting requested review from aarsilv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@typotter @leoromanovsky @schmit