Niko/react native template update #548
Conversation
* add precomputed assignments documentation for JS client * very nice! * globally * Update docs/sdks/client-sdks/javascript/precomputed-assignments.mdx Co-authored-by: Sameeran Kunche <[email protected]> --------- Co-authored-by: Sameeran Kunche <[email protected]>
* Update precomputed-assignments.mdx evaluation example * Update docs/sdks/client-sdks/javascript/precomputed-assignments.mdx Co-authored-by: Sameeran Kunche <[email protected]> --------- Co-authored-by: Sameeran Kunche <[email protected]>
✅ Deploy Preview for eppo-data-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…bandits aren't in the client SDKs per the spreadsheet.
There was a problem hiding this comment.
Thanks for going over the React Native docs as well! Lots of great changes in here 👏
I left a bunch of comments but am requesting changes for a few main reasons:
- We should remove the old React Native section
- Currently, React Native SDK doesn't support persistent caching; we should remove all references
- There are some initialization options not yet exposed to React Native SDK that we should remove
| <FeatureCard | ||
| title="API Reference" | ||
| description="Reference for all SDK methods." | ||
| link="https://github.com/Eppo-exp/react-native-sdk" |
There was a problem hiding this comment.
This is not an API reference. These docs themselves are basically the API reference
There was a problem hiding this comment.
We do have the API reference docs generated for the generic JS client which, if I understand correctly, is shared between the JS, Node, and React Native SDKs, right? So I figured pointing towards it would be okay and possibly helpful. I can remove this if that is not the case. Let me know what you would prefer.
|
|
||
|
|
||
| ## Advanced Configuration | ||
| Basic initialization is great for most use cases, but the SDK provides options that you can use during initialization to customize the behavior of the SDK. |
There was a problem hiding this comment.
We also have a baseUrl option which is where the SDK fetches configurations from. Some customers override this went they proxy configuration requests.
There was a problem hiding this comment.
I've added an ApiOptionReference component for that in the commit I'm about to push. Could you check it and confirm that everything is in order?
* Updating redirects
* Update to include * LandingPageC => ControlLandingPage * Fixing weird User assignment issue. * Making quotation use in code samples consistently " instead of '
* Remove Skip Initial Request, Update on Fetch, Use Expired Cache API Option Refs * Removing Offline Mode and Config Caching. * Adding BaseURL
* Adding Integer as an option
|
@aarsilv I think I've hit all of the updates you requested. Let me know if you're cool with me merging. Last steps for me are to deal with the merge conflicts in the redirect file and possibly rebase if any other conflicts exist. Otherwise, this should be good to go. |
|
Looks like no merge conflicts. We're good to merge whenever. |
Updating the React Native SDK docs to use the new template for SDK docs.
Dependent on the Docusaurus 2.x -> 3.x update. Don't merge until that is in.