Niko/android to new template #550
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add precomputed assignments documentation for JS client * very nice! * globally * Update docs/sdks/client-sdks/javascript/precomputed-assignments.mdx Co-authored-by: Sameeran Kunche <[email protected]> --------- Co-authored-by: Sameeran Kunche <[email protected]>
* Update precomputed-assignments.mdx evaluation example * Update docs/sdks/client-sdks/javascript/precomputed-assignments.mdx Co-authored-by: Sameeran Kunche <[email protected]> --------- Co-authored-by: Sameeran Kunche <[email protected]>
…droid SDK documentation and clean up the introduction section by removing the API Reference card.
✅ Deploy Preview for eppo-data-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
felipecsl
requested changes
Dec 18, 2024
|
|
||
| ```groovy | ||
| dependencies { | ||
| implementation 'cloud.eppo:android-sdk:4.0.0' |
There was a problem hiding this comment.
mind bumping this version to 4.3.3 which is the latest?
Suggested change
| implementation 'cloud.eppo:android-sdk:4.0.0' | |
| implementation 'cloud.eppo:android-sdk:4.3.3' |
|
|
||
| ### Initialize the SDK | ||
|
|
||
| First, initialize the SDK with your API key. You'll need to do this early in your application lifecycle, typically in your Application class: |
There was a problem hiding this comment.
Suggested change
| First, initialize the SDK with your API key. You'll need to do this early in your application lifecycle, typically in your Application class: | |
| First, initialize the SDK with your API key. You'll need to do this early in your application lifecycle, typically in your `Application` subclass: |
| EppoClient eppoClient = EppoClient.getInstance(); | ||
|
|
||
| String flagKey = "new-landing-page"; | ||
| String subjectKey = getUserId() || "anonymous"; |
There was a problem hiding this comment.
you can't use the || operator like this in Java (unlike Javascript).
You have to do instead:
String subjectKey = getUserId() != null ? getUserId() : "anonymous";
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split Android SDK Documentation into Multiple Pages
Changes Made
Restructured single android.md file into multiple focused pages:
Why?
Review instructions
To Do before Merge