fix(events): Ensure Event timestamp is sent as epoch milliseconds #201
Conversation
🦋 Changeset detectedLatest commit: 1db3792 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@felipecsl @petzel Is there any reason we do numeric timestamps for event ingestion instead of strings as the rest of APIs? |
I can't recall any particular reason other than the fact that this navigates through multiple layers in the backend and having an epoch milliseconds number is easier to parse across multiple languages and frameworks I suppose. |
|
|
||
| #[serde_as] |
There was a problem hiding this comment.
We don't need serde_as if we don't use serde_as attribute below (we're using serde(with))
| #[serde_as] |
| pub payload: serde_json::Value, | ||
| } | ||
| } |
There was a problem hiding this comment.
nit: please keep newlines at the end of files. Otherwise, git is detecting the last line as changes if we add new code after it (which results in dirty git history, which may hurt some git archeology in the future)
Description
Event timestamp field should be sent as epoch milliseconds numeric value instead of datetime string.
Testing
Wrote a test
FF-3962