feat: implement overrides store functionality #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yfrancis
changed the title
aarsilv
reviewed
Dec 21, 2024
src/configuration-factory.ts
Outdated
| @@ -79,6 +81,33 @@ export function configurationStorageFactory( | |||
| return new MemoryOnlyConfigurationStore(); | |||
| } | |||
|
|
|||
| export function overridesStorageFactory( | |||
There was a problem hiding this comment.
I wonder if we should take advantage of configurationStorageFactory either by templetizing it or using the template pattern. Then we'd have chrome storage support as well.
yfrancis
force-pushed
the
yf-overrides
branch
from
bd737b6 to
2ca704d
Compare
yfrancis
force-pushed
the
yf-overrides
branch
from
6b2a10b to
420fe2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new config parameter
enableOverrides, which when set will create an overrides store and supply it to the eppo client on init. The overrides store leverages a hybrid store with memory and window localStorage for persistence.Depends on Eppo-exp/js-sdk-common#184