Skip to content

Commit

Permalink
use hardcoded sdkName and sdkVersion parameters (FF-962) (#10)
Browse files Browse the repository at this point in the history
* use hardcoded sdkName and sdkVersion parameters (FF-962)

* use constants
  • Loading branch information
leoromanovsky authored Oct 5, 2023
1 parent bd9b6b0 commit c52eab3
Show file tree
Hide file tree
Showing 2 changed files with 25 additions and 14 deletions.
18 changes: 4 additions & 14 deletions src/Config/SDKData.php
Original file line number Diff line number Diff line change
Expand Up @@ -2,35 +2,25 @@

namespace Eppo\Config;

use Composer\InstalledVersions;

class SDKData
{
/** @var string */
private $sdkVersion;

/** @var string */
private $sdkName;

public function __construct()
{
$this->sdkVersion = InstalledVersions::getRootPackage()['version'];
$this->sdkName = InstalledVersions::getRootPackage()['name'];
}
const SDK_VERSION = '1.2.1';
const SDK_NAME = 'eppo-php-sdk';

/**
* @return string
*/
public function getSdkVersion(): string
{
return $this->sdkVersion;
return self::SDK_VERSION;;
}

/**
* @return string
*/
public function getSdkName(): string
{
return $this->sdkName;
return self::SDK_NAME;
}
}
21 changes: 21 additions & 0 deletions tests/SDKDataTest.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?php

namespace Eppo\Tests;

use Eppo\Config\SDKData;
use PHPUnit\Framework\TestCase;

final class SDKDataTest extends TestCase
{
public function testGetVersion()
{
$data = new SDKData();
$this->assertEquals('1.2.1', $data->getSdkVersion());
}

public function testGetSdkName()
{
$data = new SDKData();
$this->assertEquals('eppo-php-sdk', $data->getSdkName());
}
}

0 comments on commit c52eab3

Please sign in to comment.