Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: break any long word across lines. #734

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

waugh
Copy link
Collaborator

@waugh waugh commented Jan 16, 2025

Description

If a word is too long to fit in a visible block that contains it, with this change, the browser will break the word across lines. The problem of this not happening was noticed particularly with election names; however, the present proposed solution applies very broadly, probably to all messages the app displays. Technically, it applies to everything in CSS class "MuiTypography-root", which is probably everything.

I'm not sure whether the location of the new declaration is appropriate. Prior, there were no "Mui"- declarations there, and I may be abusing the intended pattern for administering a project's use of the Material User Interface (MUI) library.

Screenshots

Mobile

Before

before_mobile

After

after_mobile

Desktop

Before

before

After

after

Related Issues

Intended to resolve #485.

Copy link
Member

@ArendPeter ArendPeter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this look great!

We can deploy it with the broad css selector for now, and we can always tweak it afterwards if there's any edge cases.

@ArendPeter ArendPeter merged commit 08ca65a into Equal-Vote:main Jan 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Election Title Overflow - Incorrect Display - Election Title and Description - test maximum length
2 participants