-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate from joinwatch to notes #246
Merged
FloatingMilkshake
merged 7 commits into
main
from
floatingmilkshake/migrate-joinwatch-to-notes
Dec 15, 2024
Merged
Migrate from joinwatch to notes #246
FloatingMilkshake
merged 7 commits into
main
from
floatingmilkshake/migrate-joinwatch-to-notes
Dec 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate joinwatch commands, add show on join/leave option to notes, migrate joinwatches to notes on bot startup
Erisa
requested changes
Dec 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, just a few things
Co-authored-by: Erisa A <[email protected]>
…pace Also try/catches migration to avoid crashing the bot in case migration fails
Erisa
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't fully test the data migration so keep an eye out after deploying to see whether it does it ok
FloatingMilkshake
deleted the
floatingmilkshake/migrate-joinwatch-to-notes
branch
December 15, 2024 19:25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves away from joinwatch in favor of notes: