Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from joinwatch to notes #246

Merged
merged 7 commits into from
Dec 15, 2024

Conversation

FloatingMilkshake
Copy link
Collaborator

Moves away from joinwatch in favor of notes:

  • Deprecates joinwatch commands
  • Adds show on join/leave option to notes
  • Migrates joinwatches to notes on bot startup

Deprecate joinwatch commands, add show on join/leave option to notes, migrate joinwatches to notes on bot startup
Copy link
Owner

@Erisa Erisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few things

Commands/InteractionCommands/JoinwatchInteractions.cs Outdated Show resolved Hide resolved
Program.cs Outdated Show resolved Hide resolved
Program.cs Outdated Show resolved Hide resolved
Program.cs Outdated Show resolved Hide resolved
Program.cs Outdated Show resolved Hide resolved
Copy link
Owner

@Erisa Erisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't fully test the data migration so keep an eye out after deploying to see whether it does it ok

@FloatingMilkshake FloatingMilkshake merged commit 43176ea into main Dec 15, 2024
2 checks passed
@FloatingMilkshake FloatingMilkshake deleted the floatingmilkshake/migrate-joinwatch-to-notes branch December 15, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants