Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites the lockdown helpers to make them more efficient. My old code for preserving overwrites was slow, inefficient and hard to read. Now lockdown is much faster, and you can actually understand what the code is doing!
Also resolves #241.
One thing I'm not sure about here is the return value for the lockdown helpers. Both
LockChannelAsync
andUnlockChannel
returnTask<bool>
, and it looks like the bool is used only to indicate success when using the lockdown interaction commands. With the rewritten helpers there isn't a situation where this bool is ever false—should it just be removed? cc @Erisa.