Fix extended voting (#3900)

EspressoSystems · Nov 20, 2024 · dde1524 · dde1524
1 parent d216c5b
commit dde1524
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/crates/task-impls/src/quorum_vote/mod.rs b/crates/task-impls/src/quorum_vote/mod.rs
@@ -224,7 +224,6 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES> + 'static, V: Versions> Handl
         )
         .await;
 
-        let is_vote_leaf_extended = self.consensus.read().await.is_leaf_extended(leaf.commit());
         if let Err(e) = submit_vote::<TYPES, I, V>(
             self.sender.clone(),
             Arc::clone(&self.quorum_membership),
@@ -236,7 +235,7 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES> + 'static, V: Versions> Handl
             Arc::clone(&self.storage),
             leaf,
             vid_share,
-            is_vote_leaf_extended,
+            false,
         )
         .await
         {
@@ -678,6 +677,11 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES>, V: Versions> QuorumVoteTaskS
         )
         .await;
 
+        let is_vote_leaf_extended = self
+            .consensus
+            .read()
+            .await
+            .is_leaf_extended(proposed_leaf.commit());
         if let Err(e) = submit_vote::<TYPES, I, V>(
             event_sender.clone(),
             Arc::clone(&self.quorum_membership),
@@ -689,7 +693,7 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES>, V: Versions> QuorumVoteTaskS
             Arc::clone(&self.storage),
             proposed_leaf,
             updated_vid,
-            false,
+            is_vote_leaf_extended,
         )
         .await
         {