Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder changes/update hotshot #1369

Merged
merged 10 commits into from
Apr 23, 2024
Merged

builder changes/update hotshot #1369

merged 10 commits into from
Apr 23, 2024

Conversation

move47
Copy link
Contributor

@move47 move47 commented Apr 23, 2024

  • Introduces two new env variables and removes some unused env variables.
  • Updates to hotshot 0.5.41 and other relevant dependencies.

Edit: Fulfilled. REQUEST TO REVIEWERS: I am not aware of our env variables and where we run permission less-builder binary with env variables, I request reviewer to make push those relevant changes before we merge this. CI MIGHT FAIL BECAUSE OF THIS.

@move47 move47 changed the title builder changes builder changes/update hotshot Apr 23, 2024
#[clap(
short,
long,
env = "WEBSERVER_RESPONSE_TIMEOUT_DURATION",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please prefix with ESPRESSO_BUILDER

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sveitser
Copy link
Collaborator

sveitser commented Apr 23, 2024

To answer the questions the env vars are set in the .env file and if you want to pass it to docker containers also in docker-compose.yaml. Rarely they are also in the process-compose.yaml file because for the native demo the env vars in .env are all available to the binaries.

Here it looks like you have workable default values then you don't need to add anything to .env or any other files.

@move47 move47 marked this pull request as ready for review April 23, 2024 16:10
@move47 move47 merged commit 325888b into main Apr 23, 2024
16 checks passed
@move47 move47 deleted the hg/update_builder branch April 23, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants