-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
builder changes/update hotshot #1369
Conversation
#[clap( | ||
short, | ||
long, | ||
env = "WEBSERVER_RESPONSE_TIMEOUT_DURATION", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please prefix with ESPRESSO_BUILDER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To answer the questions the env vars are set in the Here it looks like you have workable default values then you don't need to add anything to |
ece9d45
to
5f6cd46
Compare
Edit: Fulfilled.
REQUEST TO REVIEWERS: I am not aware of our env variables and where we runpermission less-builder
binary with env variables, I request reviewer to make push those relevant changes before we merge this. CI MIGHT FAIL BECAUSE OF THIS.