Add the espresso-dev-node server #1709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImJeremyHe
requested review from
nomaxg,
philippecamacho,
sveitser,
jbearer and
tbro
as code owners
sveitser
reviewed
Jul 15, 2024
| .map_err(|err| io::Error::new(io::ErrorKind::Other, err))?; | ||
|
|
||
| let contract = mock_contract.clone(); | ||
| api.get("freeze", move |req, _| { |
There was a problem hiding this comment.
I think these should not be GET but POST. GET isn't supposed to have side effects.
sveitser
reviewed
Jul 15, 2024
sequencer/api/espresso_dev_node.toml
Outdated
| Get the debug info | ||
| """ | ||
|
|
||
| [route.freeze] |
There was a problem hiding this comment.
Do we need the extra indirection by introducing new terminology "freeze/unfreeze" or should we just call it set-hotshot-down/up?
There was a problem hiding this comment.
Yeah makes sense. Will use set-hotshot-down/up
ImJeremyHe
force-pushed
the
jh/dev-node-debug-endpoint
branch
from
9a7de92
to
2038cbe
Compare
ImJeremyHe
force-pushed
the
jh/dev-node-debug-endpoint
branch
from
e7550d6
to
e92c717
Compare
imabdulbasit
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1679
This PR:
This would be helpful in these cases:
dev-nodewithout specifying the ports or urls./api/dev-infoshows the urls or ports that are being used. That will be helpful when they are going to debug or report the bugs to usKey places to review:
espresso-dev-node.rsand the toml file.