-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ab/sqlite #2284
Ab/sqlite #2284
Changes from all commits
94d642d
337469c
3d8cb3e
c345591
7a8b113
8aa2ed3
164c99a
9dde077
16fc211
427c33f
a97bd18
ff44a1a
11a899d
6cc9acb
78b5abd
0d52d7f
bbcce8d
0d63fbf
a6dbd91
00db3f9
425320f
c8937e2
da75a12
993aba6
561d24b
c7190ad
9f61454
6e00a84
22eeef9
0d64fd1
80cb17c
ea320e4
0aea703
1122f62
7827c2c
8b64540
17f8f23
7c0e158
12c8e6b
403826c
9d014d5
d50cf01
a8d5209
908f9bc
ae75384
a0ca05f
18eb7b3
9902e23
70efa9a
5d5813d
8db8f96
6968baf
3430047
eab37fb
c51d674
ce1daff
dea18a5
993bf86
c794446
588fa38
f54c597
b02551a
8bb8aff
d9c22df
cdc2fd0
41a0799
897563f
f76f668
c5ce4cc
0a73fe8
3472669
9aa9c4a
975d8ee
4f28a44
bda2921
dbbe97e
6bbd9e8
521ce89
6f3479d
c181e35
a4577f1
d89a669
4635c02
09e0878
16ace39
6054b29
6e9d79c
452474b
80c8637
0574057
7487faa
0040cb0
6d4e87c
b627615
ef72571
b817446
72544fe
d43f9ad
3c6da8f
90b8276
9fee97a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,5 +32,8 @@ jobs: | |
- name: Format Check | ||
run: cargo fmt -- --check | ||
|
||
- name: Check | ||
run: cargo clippy --workspace --all-features --all-targets -- -D warnings | ||
- name: Check (embedded-db) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Confused here too. Won't There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. all-features would enable the "embedded-db" feature and so this would disable any postgres code. This is because we have #[cfg(not(feature = "embedded-db")) for the postgres code. We are doing lint check second time to see that postgres lint doesn't have any error. So one clippy run would check that sqlite lint and other one checks the postgres. The features here don't add the functionality but rather deactivate one and activate the other. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Humm is this not addressed by having sqlite in a separate package? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. its not the binary we are checking. We are checking the sequencer library with embedded-db code activated and postgres disabled and vice versa |
||
run: cargo clippy --workspace --features "embedded-db testing" --all-targets -- -D warnings | ||
|
||
- name: Check (postgres) | ||
run: cargo clippy --workspace --features testing --all-targets -- -D warnings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we explicitly specify the
embedded-db
features everywhere? I think in other places we are just specifying--all-features
which isn't clear. Especially since we were using--all-features
previously (I think).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
09e0878