~~Trying to find a foundry version that works locally and in CI~~ Sync with upstream #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e-system-config-ecotone handle the new Ecotone system config update event log type
* op-e2e: Add test demonstrating incorrect alphabet trace implementation. * rebase fixes * op-e2e: Skip known broken tests. * op-e2e: Add exhaustive alphabet test * op-challenger: fix alphabet trace provider to use l2 block number * fix up step function calculations * fix challenger tests * op-challenger: convert the absolute prestate directly to a big int * op-challenger: stash inlined calculations to implement iterative step loop * fix state data construction * fix(op-challenger): Iterative Step Loop Implementation (ethereum-optimism#8843) * Fix formatting. * op-challenger: Fix off by one error in alphabet trace provider. Updates the e2e tests to hit the case where the honest challenger calls step to prove their claim is correct. This requires the on-chain VM execution to match the challenger's version. --------- Co-authored-by: refcell <[email protected]>
…imism#8857) Bumps [golang.org/x/sync](https://github.com/golang/sync) from 0.5.0 to 0.6.0. - [Commits](golang/sync@v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/sync dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
) * Add initial bond logic * fmt * swap `BondKind` -> `Position` * Change `countered` -> `counteredBy` * Add claimant for payouts * bindings + semver lock :broom: * solvency invariant test * fmt, :broom: * Add static payouts test * Update op-challenger/game/fault/player.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * resolve conflicts * @ajsutton review * push -> pull * resolve conflicts * @refcell nit --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
ethereum-optimism#8821) * Add initial bond to `DisputeGameFactory` * Update proposer * fdg semver * fmt * bindings + semver + slither * @refcell nit
…8822) * Handle context closing on error Co-Authored-By: Sebastian Stammler <[email protected]> * Add clarifying comment --------- Co-authored-by: Sebastian Stammler <[email protected]>
* Handle context closing on error Co-Authored-By: Sebastian Stammler <[email protected]> * Add clarifying comment * Add reentrancy test for bond payouts --------- Co-authored-by: Sebastian Stammler <[email protected]>
Forgot to expand the variadic parameter...
…um-optimism#8853) * op-challenger: flatten alphabet step loop * op-challenger: add test for stepping on the max position
Better covered by unit tests since the logic is more complex than original anticipated.
…m#8868) Bumps [hardhat](https://github.com/nomiclabs/hardhat) from 2.19.2 to 2.19.4. - [Release notes](https://github.com/nomiclabs/hardhat/releases) - [Commits](https://github.com/nomiclabs/hardhat/compare/[email protected]@2.19.4) --- updated-dependencies: - dependency-name: hardhat dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…the Ecotone upgrade (ethereum-optimism#8723)" (ethereum-optimism#8865) This reverts commit b37c865.
* Implement main control logic * Add more tests
* Add API interface * Finish API Server implementation * Finish API client implementation * Finish rpc server setup in conductor * minor fixup * Fix merge issue
* contracts-bedrock: only set xDomainMsgSender on a fresh deployment * contracts-bedrock: Prevent double relaying a message with reentrancy * contracts-bedrock: bump semvers * bindings and semver-lock * contracts-bedrock: Update slither report * contracts-bedrock: Update test to demonstrate non-replayability during upgrades * contracts-bedrock: Do not reinit Portals L2 Sender if it is nonzero --wip-- * contracts-bedrock: Use assert instead of require for unreachable errors * Update L1CrossDomainMessenger.t.sol * contracts-bedrock: update semver lock, bindings, slither
…-optimism#8871) This is helpful for taking a commit & knowing when it was included in a released version. Co-authored-by: ChatGPT <[email protected]>
Co-authored-by: anikaraghu <[email protected]>
* blob encoding version 2 * - cosmetic cleanup - use testify/require for testing - improve big blob test case - some performance improvements * op-service: blob encoding nits (#10) --------- Co-authored-by: Roberto Bayardo <[email protected]> Co-authored-by: protolambda <[email protected]>
* op-node: Concrete span batch error type * op-node: add sentinel errors to variable decl block
* `KontrolDeployment`: deploy `L1CrossDomainMessenger` * KontrolInterfaces: add `IL1CrossDomainMessenger` * Add deployment summary tests for `L1CrossDomainMessenger` * Add `prove_relayMessage_paused` * `run-kontrol.sh`: add `prove_relayMessage_paused` * `run-kontrol.sh`: correct help message to install right kontrol version * Bump Kontrol version from `0.1.121` to `0.1.127` * `forge fmt` * Update `Kontrol-Deploy.json` * `README.md`: Add `L1CrossDomainMessenger.k.sol` documentation * Fix typos * Make autogenerated address names start with lowercase
Bumps [wagmi](https://github.com/wevm/wagmi/tree/HEAD/packages/react) from 2.5.0 to 2.5.1. - [Release notes](https://github.com/wevm/wagmi/releases) - [Changelog](https://github.com/wevm/wagmi/blob/main/packages/react/CHANGELOG.md) - [Commits](https://github.com/wevm/wagmi/commits/[email protected]/packages/react) --- updated-dependencies: - dependency-name: wagmi dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* op-conductor: fix ha test flakiness * 3rd try * 4th try * 1st try with everything ready * 2nd try * 3rd try * 4th try
* op-conductor: improve start sequencer logic * update * update * updated based on suggestion
…ptimism#9153) * script to compute gas config scalar after Ecotone upgrade * Update op-chain-ops/cmd/ecotone-scalar/main.go Co-authored-by: Sebastian Stammler <[email protected]> --------- Co-authored-by: Sebastian Stammler <[email protected]>
Bumps [dotenv](https://github.com/motdotla/dotenv) from 16.3.2 to 16.4.1. - [Changelog](https://github.com/motdotla/dotenv/blob/master/CHANGELOG.md) - [Commits](motdotla/dotenv@v16.3.2...v16.4.1) --- updated-dependencies: - dependency-name: dotenv dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* contracts-bedrock: deprecate deployments There is no reason to keep the legacy hardhat deploy artifacts around anymore. It just adds complexity to the codebase. With the advent of the superchain, it no longer makes sense to hold on to these artifacts here. The contract addressses now live in the superchain-registry. The legacy abis live in git history or release tags. For what its worth, the `deployments` directory is already out of date and the superchat registry should be considered the source of truth. Deleting these files will reduce the size of a cloned repo. The entire `deployments` directory is not yet fully removed because it is used to write the `.deploy` artifact after the forge deployment script runs. This will also change in the future but do not want to make too large of changes at once. The `.deploy` file will be configurable where it is written to and it will interoperate well with the `superchain-registry` repo. * sdk: remove imports of deploy artifacts * chain-mon: remove dead import
…one (ethereum-optimism#9182) * Fix: Pass excess blob and blob gas used params * Add missing parent beacon block property
…m#9185) * op-signer: update client to support Blob tx signing * op-service: update maxFeePerBlobGas JSON field to match internal geth TransactionArgs
…m#9166) * op-challenger: Implement verification for preimages Identifies the leaf to challenge, but doesn't yet produce the merkle proofs required and can't actually send the transaction. * op-challenger: Review feedback. * op-challenger: Avoid nil
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## release-gibraltar #98 +/- ##
======================================================
- Coverage 49.77% 28.12% -21.66%
======================================================
Files 78 168 +90
Lines 4261 7339 +3078
Branches 531 1246 +715
======================================================
- Hits 2121 2064 -57
- Misses 2090 5154 +3064
- Partials 50 121 +71
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
|
jbearer
changed the title
jbearer
force-pushed
the
fix/foundry-version
branch
from
461524a
to
e42292e
Compare
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been trying to find a foundry version that doesn't have the weird JSON encoding bug in CI. After finding a version that works locally but not in CI (!) I got fed up. It seems that upstream has fixed this issue with a complete refactor of the artifact generation scripts, so I decided to just sync instead