Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples/hey_gis_give_me_a_map_of_the_recent_natural_disasters #2117

Open
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

nparavicini7
Copy link
Collaborator

Updated the text and some of the mapping calls, but need some sage wisdom from Nanae about some of the other mapping stuff first before merging. Mainly:

  1. Hit command f to find the cell about "show_styles". Is there any replacement of that functionality in the new stuff?
  2. Is there a take_screenshot method or something comparable in new widget?
  3. Does spatial.plot on dataframes still work the same or should we adjust around that?

Thanks and lmk :)

@nparavicini7 nparavicini7 added documentation Bugs and enhancement requests for doc (API ref and notebooks) DO NOT MERGE Sample Notebook labels Oct 18, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Oct 21, 2024

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-10-21T08:08:04Z
----------------------------------------------------------------

We removed show styles for now... this is something we might want to re-imagine a bit before integrating since we now use the dataclasses. But no one-to-one as of now


Copy link

review-notebook-app bot commented Oct 21, 2024

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-10-21T08:08:05Z
----------------------------------------------------------------

plot now takes a renderer dataclass rather than individual symbol information. So you make a simple renderer and add in the symbol there.


Copy link

review-notebook-app bot commented Oct 21, 2024

View / edit / reply to this conversation on ReviewNB

nanaeaubry commented on 2024-10-21T08:08:06Z
----------------------------------------------------------------

You can replace with export_to_html since that is mentioned in the comment. But take screenshot we decided not to include. There is also a print method. So maybe change the text to:

" Alternatively, you can either print to PDF of the current map, or export it to a local HTML file. "

And then change the code to one or the other. Take screenshot was used because it shows the map rather than the file path is my guess


@nanaeaubry
Copy link
Contributor

@nparavicini7 Left some comments for your questions, let me know if you need more info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE documentation Bugs and enhancement requests for doc (API ref and notebooks) Sample Notebook
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants