Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update River Turbidity Sample #2126

Merged
merged 7 commits into from
Jan 16, 2025
Merged

Update River Turbidity Sample #2126

merged 7 commits into from
Jan 16, 2025

Conversation

nanaeaubry
Copy link
Contributor

remove use of credentials
update to use new map methods

jyaistMap and others added 4 commits September 26, 2024 13:14
Aligning next with master for relative links
aligning branches so next is only ahead of master
@nanaeaubry nanaeaubry added the documentation Bugs and enhancement requests for doc (API ref and notebooks) label Oct 22, 2024
@nanaeaubry nanaeaubry requested a review from jyaistMap October 22, 2024 12:16
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@nanaeaubry nanaeaubry changed the base branch from next to master October 24, 2024 15:08
Copy link

review-notebook-app bot commented Oct 30, 2024

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-10-30T03:52:57Z
----------------------------------------------------------------

I didn't find the 'national-geographic' type of basemap from the basemaps list. Not sure if it is using another name in the list. If not, we may need to either add this style to set the basemap, or use a similar one from the list?


nanaeaubry commented on 2024-10-30T14:54:31Z
----------------------------------------------------------------

Oh you're right let's go with 'terrain'

Copy link

review-notebook-app bot commented Oct 30, 2024

View / edit / reply to this conversation on ReviewNB

cariashuang0417 commented on 2024-10-30T03:52:58Z
----------------------------------------------------------------

MapView.sync_navigation link is out-of-dated


Copy link
Contributor

@cariashuang0417 cariashuang0417 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a question and a comment for a little change needed

Copy link
Contributor Author

Oh you're right let's go with 'terrain'


View entire conversation on ReviewNB

Copy link
Collaborator

@jyaistMap jyaistMap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update with code to add layer before zooming to it
@nanaeaubry
Copy link
Contributor Author

@jyaistMap Thanks merged your change in!

@nanaeaubry nanaeaubry requested a review from jyaistMap January 16, 2025 10:32
@jyaistMap jyaistMap merged commit 3285c2e into master Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Bugs and enhancement requests for doc (API ref and notebooks)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants