Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates_for_designate_bike_routes_sample_24 #2129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updates_for_designate_bike_routes_sample_24 #2129

wants to merge 1 commit into from
+261 −389

Conversation

cariashuang0417
Copy link
Contributor

@cariashuang0417 cariashuang0417 commented Oct 22, 2024 •
edited
Loading

Updates for sample designate_bike_routes_for_commuting_professionals.ipynb

  • updated map.add_layer() to map.content.add()
  • added basemap setting for each map for better visualization of the bike routes
  • updated map screenshots
  • removed tapestry segment item since it is using pop-up, and the data was broken from the portal

@cariashuang0417 cariashuang0417 added documentation Bugs and enhancement requests for doc (API ref and notebooks) update_24 labels Oct 22, 2024
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

nanaeaubry
nanaeaubry approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@nanaeaubry nanaeaubry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nanaeaubry
Copy link
Contributor

@cariashuang0417 Do we still want the notebooks to be in next branch or we are going straight to master now?

ManushiM
ManushiM approved these changes Oct 23, 2024
View reviewed changes
Copy link
Collaborator

@ManushiM ManushiM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cariashuang0417
Copy link
Contributor Author

@cariashuang0417 Do we still want the notebooks to be in next branch or we are going straight to master now?

@nanaeaubry , I remember @jyaistMap mentioned that this time we will use the master branch for the left samples and guides. He will get it merged to next before next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nanaeaubry nanaeaubry nanaeaubry approved these changes

@ManushiM ManushiM ManushiM approved these changes

@jyaistMap jyaistMap Awaiting requested review from jyaistMap

@tarunkukreja003 tarunkukreja003 Awaiting requested review from tarunkukreja003

Assignees
No one assigned
Labels
documentation Bugs and enhancement requests for doc (API ref and notebooks) update_24
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cariashuang0417 @nanaeaubry @ManushiM