Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Üpdated Flood Inundation änd Other Notebooks #2161

Open
wants to merge 6 commits into
base: next
Choose a base branch
from

Conversation

neha-sharma-geoai
Copy link
Collaborator

I've updated the flood inundation notebook using the latest map widget and data source.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

review-notebook-app bot commented Nov 25, 2024

View / edit / reply to this conversation on ReviewNB

jyaistMap commented on 2024-11-25T23:24:40Z
----------------------------------------------------------------

  • Running this cell creates a map similar to the image above, but the zoom level is 9, not 5.

    image

    The zoom attribute does not apply to the new map widget unless the map has already been drawn.

  • If you want the map to appear as in the screenshot above, please remove the m1.zoom = 5 line
  • If you want the map to appear at zoom level 5, please remove it from this cell and place it in a cell by itself just below the rendered map



image

Copy link

review-notebook-app bot commented Nov 25, 2024

View / edit / reply to this conversation on ReviewNB

jyaistMap commented on 2024-11-25T23:24:41Z
----------------------------------------------------------------

The last sentence above is not a complete sentence. Mosaicking two rasters with OBJECT ID....suing predefined mosaic by function... what does Mosaicking does what?


Copy link

review-notebook-app bot commented Nov 25, 2024

View / edit / reply to this conversation on ReviewNB

jyaistMap commented on 2024-11-25T23:24:42Z
----------------------------------------------------------------

  • returns an error
---------------------------------------------------------------------------
AttributeError                            Traceback (most recent call last)
Cell In[52], line 1
----> 1 clip_out_name = 'saharanpur_raster_clip ' + str(datetime.date.today()).replace("-", "")
      2 clip.save(clip_out_name, gis = gis)

AttributeError: 'method_descriptor' object has no attribute 'today'


Copy link

review-notebook-app bot commented Nov 25, 2024

View / edit / reply to this conversation on ReviewNB

jyaistMap commented on 2024-11-25T23:24:43Z
----------------------------------------------------------------

Running the code as is will draw a map at zoom level 10.

image

The image in the notebook is actually at zoom level 8. Please add a line below the rendered map that sets the zoom level to 8. m2.zoom = 8

image

Copy link
Collaborator

@jyaistMap jyaistMap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • the detecting settlements notebook needs changes. I did not run any of the deep learning functionality as I do not have an environment with it installed. But I ran the map widget portion of the the first notebook and some things need changed.

  • the other 3 notebooks look good from what I can see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants