-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.4.0 map widget changes to temperature forecast sample #2162
base: master
Are you sure you want to change the base?
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks @ManushiM !
@@ -69,7 +69,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the england_map.zoom = 6
from these lines and place it in a cell below the map by itself.
Reply via ReviewNB
@@ -69,7 +69,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- same comment. Setting the zoom level before the map is rendered does not recognize the value, but instead uses a default zoom level based on location information.
Reply via ReviewNB
@@ -69,7 +69,7 @@ | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the eng_interpolated_temp.zoom = 6
line to a cell below the rendered map.
Reply via ReviewNB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ManushiM. Just need to move map.zoom = level
lines to a cell after the map has already been drawn.
Changes that reflect the new map widget changes.
refer to ArcGIS:geosaurus/12343
Checklist
Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.
import
s are in the first cell?arcgis
imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.GIS
object instantiations are one of the following?gis = GIS()
gis = GIS('home')
orgis = GIS('pro')
gis = GIS(profile="your_online_portal")
gis = GIS(profile="your_enterprise_portal")
./misc/setup.py
and/or./misc/teardown.py
?api_data_owner
user?api_data_owner
account and change the notebook to first download and unpack the files.<img src="base64str_here">
instead of<img src="https://some.url">
? All map widgets contain a static image preview? (Callmapview_inst.take_screenshot()
to do so)os.path.join()
? (Instead ofr"\foo\bar"
,os.path.join(os.path.sep, "foo", "bar")
, etc.)Export Training Data Using Deep Learning
tool published on geosaurus org (api data owner account) and added in the notebook usinggis.content.get
function?gis.content.get
function? Note: This includes providing test raster and trained model.