fix(list): Stop emitting calciteListChange when a list-item is disabl…

…ed or closed. (#7624) **Related Issue:** #7627 ## Summary - calciteListChange shouldn't be emitting when an item is disabled or closed.
Esri · Aug 31, 2023 · 7008463 · 7008463
1 parent 79c3d56
commit 7008463
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/packages/calcite-components/src/components/list/list.e2e.ts b/packages/calcite-components/src/components/list/list.e2e.ts
@@ -391,10 +391,12 @@ describe("calcite-list", () => {
 
       expect(await isElementFocused(page, "#two")).toBe(true);
 
+      const calciteListChange = await page.spyOnEvent("calciteListChange");
       const listItemThree = await page.find("#three");
       listItemThree.setProperty("disabled", false);
       await page.waitForChanges();
       await page.waitForTimeout(listDebounceTimeout);
+      expect(calciteListChange).toHaveReceivedEventTimes(0);
 
       await list.press("ArrowDown");
 
@@ -404,6 +406,7 @@ describe("calcite-list", () => {
       listItemFour.setProperty("closed", false);
       await page.waitForChanges();
       await page.waitForTimeout(listDebounceTimeout);
+      expect(calciteListChange).toHaveReceivedEventTimes(0);
 
       await list.press("ArrowDown");
 

diff --git a/packages/calcite-components/src/components/list/list.tsx b/packages/calcite-components/src/components/list/list.tsx
@@ -279,7 +279,7 @@ export class List implements InteractiveComponent, LoadableComponent, SortableCo
     }
 
     event.stopPropagation();
-    this.updateListItems(true);
+    this.updateListItems();
   }
 
   @Listen("calciteInternalListItemGroupDefaultSlotChange")