Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up on remaining Lumina migration notes #10731

Open
1 of 5 tasks
jcfranco opened this issue Nov 15, 2024 · 0 comments
Open
1 of 5 tasks

Follow up on remaining Lumina migration notes #10731

jcfranco opened this issue Nov 15, 2024 · 0 comments
Assignees
Labels
1 - assigned Issues that are assigned to a sprint and a team member. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.

Comments

@jcfranco
Copy link
Member

jcfranco commented Nov 15, 2024

Description

In addition to the migration notes added by #10310, the following should be addressed as well:

Stabilize

☑️ – no longer shows up

@esri/calcite-components:test:  FAIL  src/components/combobox/combobox.e2e.ts > calcite-combobox > reflects > %p scale
@esri/calcite-components:test: Error: vitest-fail-on-console > Expected test not to call console.error().
@esri/calcite-components:test:     If the error is expected, test for it explicitly by mocking it out using: 
@esri/calcite-components:test:     vi.spyOn(console, 'error').mockImplementation(() => {}) 
@esri/calcite-components:test:     and test that the warning occurs.
@esri/calcite-components:test: 
@esri/calcite-components:test: "chevronDown16" is not a valid calcite-ui-icon name 
@esri/calcite-components:test: Stack:
@esri/calcite-components:test:   http://localhost:5173/src/components/icon/utils.ts:23:14
@esri/calcite-components:test: 
@esri/calcite-components:test:     at Console.l [as error] (file:///home/runner/work/calcite-design-system/calcite-design-system/node_modules/vitest-fail-on-console/src/index.ts:90:31)
@esri/calcite-components:test:     at ae (file:///home/runner/work/calcite-design-system/calcite-design-system/node_modules/@arcgis/lumina-compiler/dist/puppeteerTesting/index.js:2:1926)
@esri/calcite-components:test:  ❯ Console.l [as error] ../../node_modules/vitest-fail-on-console/src/index.ts:90

✅ – #10818

@esri/calcite-components:test: 
@esri/calcite-components:test:  FAIL  src/components/segmented-control/segmented-control.e2e.ts > calcite-segmented-control > when multiple items are checked, last one wins
@esri/calcite-components:test: AssertionError: expected '1' to be '3' // Object.is equality
@esri/calcite-components:test: 
@esri/calcite-components:test: Expected: "3"
@esri/calcite-components:test: Received: "1"

Proposed Advantages

Cleaner, simpler code.

Which Component

N/A

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components
@jcfranco jcfranco added refactor Issues tied to code that needs to be significantly reworked. 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. labels Nov 15, 2024
@jcfranco jcfranco added this to the 2024-12-17 - Dec Milestone milestone Nov 15, 2024
@jcfranco jcfranco self-assigned this Nov 15, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Nov 15, 2024
jcfranco added a commit that referenced this issue Dec 4, 2024
…10952)

**Related Issue:** #10731

## Summary

Tweaks initialization logic to prevent extraneous change event that
happened after #10310.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - assigned Issues that are assigned to a sprint and a team member. calcite-components Issues specific to the @esri/calcite-components package. estimate - 5 A few days of work, definitely requires updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Development

No branches or pull requests

1 participant