Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: migrate to Lumina #10482

Merged
merged 113 commits into from
Nov 15, 2024
Merged

refactor!: migrate to Lumina #10482

merged 113 commits into from
Nov 15, 2024

Conversation

maxpatiiuk
Copy link
Member

@maxpatiiuk maxpatiiuk commented Oct 3, 2024 •
edited by jcfranco
Loading

Related Issue: #10310, #10481, #10399, #10405, #10491, #10434, #10495, #9260

Noteworthy changes

  • components are now Lit-based
  • removed @storybook/test and @storybook/addon-interactions as these were not being actively used
  • Added default scale value to:
    • action-bar
    • action-group
    • action-menu
    • action-pad
  • Path of extras will change to the following:
    • /dist/extras/vscode-data.json ➡️ /dist/docs/vscode.html-custom-data.json
    • /dist/extras/docs-json.json ➡️ /dist/docs/docs.json (internal)
    • /dist/extras/translations-json.json ➡️ /dist/docs/translations.json (internal)
    • /dist/extras/docs-json.d.ts ❌ (removed, internal)

BREAKING CHANGE:

  • for a consistent development experience, components now convert null to undefined, so developers will need to update code with strict null checks
  • removed the following @esri/eslint-plugin-calcite-components rules as they are no longer valid:
    • ban-props-on-host
    • enforce-ref-last-prop
    • require-event-emitter-type

@github-actions github-actions bot added the refactor Issues tied to code that needs to be significantly reworked. label Oct 3, 2024
@maxpatiiuk maxpatiiuk mentioned this pull request Oct 8, 2024
Closed
5 tasks
@benelan benelan mentioned this pull request Oct 21, 2024
Closed
@jcfranco jcfranco mentioned this pull request Oct 23, 2024
Open
@jcfranco jcfranco changed the title refactor: migrate to Lumina refactor!: migrate to Lumina Oct 23, 2024
@benelan benelan mentioned this pull request Oct 31, 2024
Merged
benelan added a commit that referenced this pull request Oct 31, 2024
@benelan
refactor: handle stencil/lumina boolean reflection differences (#10662)
32b057c 
**Related Issue:** #10482

## Summary

Resolve the `validationIcon` issue brought up in
#10509 (comment)

The only properties affected by the change in how boolean properties are
reflected are `icon`, `validationIcon`, and `download`. This PR fixes
the utils that caused issues with `icon` and `validationIcon`. The
`download` property seems to already be correct, for example:


https://github.com/Esri/calcite-design-system/blob/25319998739c3af17a5438d285c5931ea656285d/packages/calcite-components/src/components/link/link.tsx#L178
@benelan benelan mentioned this pull request Nov 5, 2024
Closed
@benelan benelan mentioned this pull request Nov 5, 2024
Merged
jcfranco and others added 7 commits November 5, 2024 14:19
@jcfranco
sync all lumina deps
e1656f3
@jcfranco
remove ignore lines for @stencil-community/eslint-plugin rules
5c44ccb
@jcfranco
make messages internal
0805f61
@jcfranco
drop unnecessary react-wrapper patch
d5f19d1
@benelan @calcite-admin @renovate
build(deps): cherry pick updates from dev (#10694)
7ccd607 
**Related Issue:** #10482

## Summary

- **build: update browserslist db (#10629)**
- **docs(angular): update example to use custom elements directly
(#10686)**
- **build(deps): update dependency @floating-ui/dom to v1.6.12
(#10681)**
- **build(deps): update dependency @cspell/eslint-plugin to v8.15.6
(#10680)**
- **build(deps): update dependency chokidar to v4 (#10643)**

---------

Co-authored-by: Calcite Admin <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@jcfranco
remove Stencil logic from custom ESLint rules
065951c
@jcfranco
refactor(table): refactor internals to work around HTML parser issue (#…
0979376 
…10649)

**Related Issue:** #10495

## Summary

Split up table rendering to bypass HTML parser corrections that would
break functionality and styling.
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 14, 2024
@jcfranco jcfranco added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Nov 15, 2024
@jcfranco jcfranco added the skip visual snapshots Pull requests that do not need visual regression testing. label Nov 15, 2024
@jcfranco
Copy link
Member

Created issue for follow-up items: #10731.

@jcfranco
Copy link
Member

Proceeding to merge. We can use #10731 if anything needs addressing. 🚀

@jcfranco jcfranco merged commit b2c9762 into dev Nov 15, 2024
12 checks passed
@jcfranco jcfranco deleted the lumina branch November 15, 2024 04:47
maxpatiiuk
maxpatiiuk commented Nov 15, 2024
View reviewed changes
packages/calcite-components/vite.config.ts Outdated
@@ -43,6 +45,15 @@ export default defineConfig({
},
},
}),
replace({
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(optional) vite provides env variables support without a plugin, so if you don't need extra customization options you can use that to keep build config simpler and performance better: https://vite.dev/guide/env-and-mode

@jcfranco jcfranco mentioned this pull request Nov 20, 2024
Merged
jcfranco added a commit that referenced this pull request Nov 20, 2024
@jcfranco
fix(flow-item): fix TS error caused by FlowItemLike type (#10802)
22c46c7 
**Related Issue:** #10801

## Summary

Restores internal prop that was unintentionally made private by #10482.
@jcfranco jcfranco mentioned this pull request Nov 20, 2024
Merged
jcfranco added a commit that referenced this pull request Nov 20, 2024
@jcfranco
chore: fix storybook GH pages deployment (#10807)
a9c9e0e 
**Related Issue:** N/A

## Summary

#10482 caused a break in our GitHub deployment. This fix addresses it
by:

* Adding a `.nojekyll` file to the pages folder to prevent files with
leading underscores in their names from being excluded (see
https://github.blog/news-insights/bypassing-jekyll-on-github-pages/).
* Moving the internal-testing notice to the preview head to leverage the
lazy-loaded components in the preview.
* We can revisit restoring this in the manager head after
storybookjs/builder-vite#486 is resolved.
This was referenced Nov 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcfranco jcfranco Awaiting requested review from jcfranco jcfranco is a code owner

@benelan benelan Awaiting requested review from benelan benelan is a code owner

@geospatialem geospatialem Awaiting requested review from geospatialem geospatialem is a code owner

Assignees

@jcfranco jcfranco

@maxpatiiuk maxpatiiuk

Labels
pr ready for visual snapshots Adding this label will run visual snapshot testing. refactor Issues tied to code that needs to be significantly reworked. skip visual snapshots Pull requests that do not need visual regression testing.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

Successfully merging this pull request may close these issues.
3 participants
@maxpatiiuk @jcfranco @benelan