Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sheet): add resizable property #10521

Merged
merged 47 commits into from
Dec 12, 2024
Merged

feat(sheet): add resizable property #10521

merged 47 commits into from
Dec 12, 2024

Conversation

driskull
Copy link
Member

@driskull driskull commented Oct 10, 2024 •
edited
Loading

Related Issue: #7591

Summary

@github-actions github-actions bot added the enhancement Issues tied to a new feature or request. label Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Oct 21, 2024
@driskull driskull marked this pull request as ready for review October 21, 2024 18:01
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed Stale Issues or pull requests that have not had recent activity. labels Oct 21, 2024
@driskull
Merge branch 'dev' into dris0000/sheet-resizable-codemod
b6429e9 
# Conflicts:
#	packages/calcite-components/src/components/dialog/dialog.tsx
#	packages/calcite-components/src/components/sheet/sheet.e2e.ts
#	packages/calcite-components/src/components/sheet/sheet.tsx
@driskull
cleanup
e706d85
@driskull
cleanup
d1c821b
@driskull
cleanup
0c2dbd6
@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Nov 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

@github-actions github-actions bot added the Stale Issues or pull requests that have not had recent activity. label Nov 26, 2024
@driskull
Merge branch 'dev' into dris0000/sheet-resizable
1dbfb7a 
# Conflicts:
#	packages/calcite-components/src/components/dialog/dialog.tsx
#	packages/calcite-components/src/components/sheet/resources.ts
#	packages/calcite-components/src/components/sheet/sheet.e2e.ts
#	packages/calcite-components/src/components/sheet/sheet.scss
#	packages/calcite-components/src/components/sheet/sheet.tsx
@driskull
css
da3701b
@driskull
Merge branch 'dev' into dris0000/sheet-resizable
7b0dea4
@driskull
wip
28e1078
@driskull
cleanup
3ce6e2e
@driskull driskull requested a review from geospatialem December 4, 2024 00:24
@driskull
Copy link
Member Author

driskull commented Dec 4, 2024

@SkyeSeitz @ashetland can you review again?

@github-actions github-actions bot removed the Stale Issues or pull requests that have not had recent activity. label Dec 4, 2024
@driskull driskull added the pr ready for visual snapshots Adding this label will run visual snapshot testing. label Dec 6, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 7, 2024
@driskull driskull added pr ready for visual snapshots Adding this label will run visual snapshot testing. and removed pr ready for visual snapshots Adding this label will run visual snapshot testing. labels Dec 7, 2024
@driskull
Copy link
Member Author

driskull commented Dec 9, 2024

@SkyeSeitz @ashetland can you review/accept the screenshots?

SkyeSeitz
SkyeSeitz approved these changes Dec 9, 2024
View reviewed changes
Copy link

@SkyeSeitz SkyeSeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg2m!

@driskull driskull merged commit 927eef5 into dev Dec 12, 2024
14 checks passed
@driskull driskull deleted the dris0000/sheet-resizable branch December 12, 2024 22:33
@github-actions github-actions bot added this to the 2024-12-17 - Dec Milestone milestone Dec 12, 2024
@driskull
Copy link
Member Author

@jcfranco merged. Let me know if any changes are needed.

benelan pushed a commit that referenced this pull request Feb 8, 2025
@driskull @benelan
feat(sheet): add resizable property (#10521)
e599ae0 
**Related Issue:** #7591

## Summary

- adds resize functionality
- adds assistive text live region for keyboard instructions
- adds tests
- updates story
- adds dom utility
- adds t9n files
- use new resize icon
- uses separator role, related to #3535
@calcite-admin calcite-admin mentioned this pull request Feb 8, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benelan benelan benelan approved these changes

@SkyeSeitz SkyeSeitz SkyeSeitz approved these changes

@jcfranco jcfranco Awaiting requested review from jcfranco jcfranco is a code owner

@ashetland ashetland Awaiting requested review from ashetland

@geospatialem geospatialem Awaiting requested review from geospatialem

Assignees

@driskull driskull

Labels
enhancement Issues tied to a new feature or request. pr ready for visual snapshots Adding this label will run visual snapshot testing.
Projects
None yet
Milestone
2024-12-17 - Dec Milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@driskull @SkyeSeitz @geospatialem @ashetland @benelan