fix(input-date-picker, input-time-picker, modal, sheet): closes on escape when focusTrap is disabled

[Elijbet]

Related Issue: #10522

Summary

Close on Escape works when focusTrap is disabled.

[driskull]

Instead of creating this event on the window, can we add it on the host of the component? That way, it won't close for an escape that happens outside of the component.

[driskull]

Same thing with the modal component. Although less important since the modal is deprecated :D

[Elijbet]

Oh, I initially had it on host but @jcfranco thinks we should close the modal/sheet regardless of where esc occurs.

[driskull]

Ok. However, when we refactor sheet to support #10364, this would need to move to the host when non modal. It might be better to just have it on sheets host for now. I'll defer to @jcfranco

[driskull]

When a sheet can be non modal, we wouldn't want escape closing it from outside of the sheet.

[driskull]

👍

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

[Elijbet]

As per group discussion. @geospatialem @jcfranco @SkyeSeitz @ashetland @driskull

• dialog with modal: no support for focusTrapDisabled

  • Technically we don't offer this in dialog currently so this is and once modal is removed we're good to go

• dialog: offer focusTrapDisabled depending on workflows

  • New attr/prop, not enabled by default
  • Example of where this is useful, a cookie page dialog that mentions cookie tracking, but the user can still interact with the page without acknowledgement/acceptance

• input-date-picker / input-time-picker: offer focusTrapDisabled depending on workflows

  • Not enabled by default
  • We already offer this, so no action needed if we agree on the approach
  • It could make sense depending on what the user is implementing in their UI/Ux

• sheet: offers focusTrapDisabled

  • Not enabled by default
  • We already offer this, so no action needed

[driskull]

input-date-picker / input-time-picker: offer focusTrapDisabled depending on workflows

I think for the future we should plan to deprecate focusTrapDisabled at some point and have these components no longer support any focus trapping. They should act like a single component and be controlled via arrow keys only so tabbing past them is easier for an end user.

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions.

[jcfranco]

Awesome, @Elijbet! Once comments are addressed, this is good to go! ✨🚀✨

[Elijbet]

Note: With this change it will only be closing on Escape when focus trap is disabled if the event is emitted within the component (i.e., Escape won't close if focus is in another, separate, element).