chore(block): add warning message when both heading & label are empty #10887
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
chore
anveshmekala
added
the
skip visual snapshots
jcfranco
approved these changes
Nov 27, 2024
| @@ -352,6 +358,14 @@ export class Block | |||
| ); | |||
| } | |||
|
|
|||
| private handleWarningMessage(): void { | |||
| if (!this.heading && !this.label) { | |||
There was a problem hiding this comment.
Can you create a refactor issue for me to update the warnIfMissingRequiredProp util to cover this case?
jcfranco
reviewed
Nov 28, 2024
| export function warnIfMissingProps<C extends LitElement>( | ||
| component: C, | ||
| prop: keyof C, | ||
| message?: string, |
There was a problem hiding this comment.
Let's remove the message argument. Messaging for required props should be consistent. If we need to provide different messaging, we could look at introducing a context argument to help with this.
I still think we can tweak, and rename, warnIfMissingRequiredProp to achieve this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8697
Summary
Adds warning message in console when both
heading&labelproperties are set to empty.